Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfp40-0001gQ-NN for pgsql-committers@arkaria.postgresql.org; Wed, 27 Oct 2021 19:58:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mfp3y-0004E4-Lp for pgsql-committers@arkaria.postgresql.org; Wed, 27 Oct 2021 19:58:18 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfp3y-0004Dv-FV for pgsql-committers@lists.postgresql.org; Wed, 27 Oct 2021 19:58:18 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfp3v-0000nB-9X for pgsql-committers@lists.postgresql.org; Wed, 27 Oct 2021 19:58:17 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 449FC2EDA867 for ; Wed, 27 Oct 2021 21:57:43 +0200 (CEST) Received: from s630.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 35BD82F5F83A; Wed, 27 Oct 2021 21:57:43 +0200 (CEST) Received: from s475.loopia.se (unknown [172.22.191.6]) by s630.loopia.se (Postfix) with ESMTP id 2AE1F13ABE4B; Wed, 27 Oct 2021 21:57:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s499.loopia.se ([172.22.191.6]) by s475.loopia.se (s475.loopia.se [172.22.190.15]) (amavisd-new, port 10024) with LMTP id d9NpFjfCC98I; Wed, 27 Oct 2021 21:57:42 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from [192.168.72.144] (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s499.loopia.se (Postfix) with ESMTPSA id C69041CE04CE; Wed, 27 Oct 2021 21:57:42 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: pgsql: Refactor the sslfiles Makefile target for ease of use From: Daniel Gustafsson In-Reply-To: <7614BC3D-0B3B-4D9C-8801-D771042EF2B4@yesql.se> Date: Wed, 27 Oct 2021 21:57:42 +0200 Cc: pgsql-committers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: <387192BC-26E5-4D9A-A2C1-3F9AB79B7FC2@yesql.se> References: <20211026174152.jjcagswnbhxu7uqz@alap3.anarazel.de> <7614BC3D-0B3B-4D9C-8801-D771042EF2B4@yesql.se> To: Andres Freund X-Mailer: Apple Mail (2.3608.120.23.2.7) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 27 Oct 2021, at 16:37, Daniel Gustafsson wrote: >=20 >> On 26 Oct 2021, at 19:41, Andres Freund wrote: >=20 >> This fails during 'make clean' in a vpath build, because sslfiles.mk = cannot be >> found. Probably just needs >=20 > It does in fact need that diff, but sslfiles.mk also needs to be = taught about > the current $(srcdir) to properly function under VPATH for "make = sslfiles". Discussing this off-list with Jacob, and dabbling some more with it, = this needs more thought. It's not clear what make sslfiles should do in a VPATH = build, and where, since the artefacts are both generated and distributed. I've = pushed the small fix to ensure "make clean" works as that's a much more common usecase, to allow for time to discuss "make sslfiles" on -hackers. -- Daniel Gustafsson https://vmware.com/