Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZCEn-004ZXV-8j for pgsql-committers@arkaria.postgresql.org; Thu, 24 Aug 2023 15:27:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qZCEl-00A6VK-Ot for pgsql-committers@arkaria.postgresql.org; Thu, 24 Aug 2023 15:27:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZCEl-00A6VA-Gk for pgsql-committers@lists.postgresql.org; Thu, 24 Aug 2023 15:27:07 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZCEi-000nsc-85 for pgsql-committers@lists.postgresql.org; Thu, 24 Aug 2023 15:27:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 37OFR1Bu3907903; Thu, 24 Aug 2023 11:27:01 -0400 From: Tom Lane To: Andrew Dunstan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Cache by-reference missing values in a long lived context In-reply-to: References: Comments: In-reply-to Andrew Dunstan message dated "Wed, 23 Aug 2023 21:22:33 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3907901.1692890821.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 24 Aug 2023 11:27:01 -0400 Message-ID: <3907902.1692890821@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > Cache by-reference missing values in a long lived context The v11 version of this patch is causing a compiler warning for me: In file included from heaptuple.c:58: heaptuple.c: In function 'missing_hash': heaptuple.c:97:3: warning: implicit declaration of function 'hash_any'; di= d you mean 'hash_stats'? [-Wimplicit-function-declaration] hash_any((const unsigned char *) entry->value, entry->len)); ^~~~~~~~ ../../../../src/include/postgres.h:471:38: note: in definition of macro 'D= atumGetUInt32' #define DatumGetUInt32(X) ((uint32) (X)) ^ It seems to work anyway, but please fix. regards, tom lane