From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Tomas Vondra <tomas.vondra@postgresql.org>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add support for basic NUMA awareness
In-reply-to: <7ABC1680-3B82-4DD4-B9B7-BB4F74668B1A@yesql.se>
References: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
 <7ABC1680-3B82-4DD4-B9B7-BB4F74668B1A@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Tue, 08 Apr 2025 13:40:04 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3976704.1744121148.1@sss.pgh.pa.us>
Date: Tue, 08 Apr 2025 10:05:48 -0400
Message-ID: <3976705.1744121148@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3976705.1744121148%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 7 Apr 2025, at 23:18, Tomas Vondra <tomas.vondra@postgresql.org> wrote:
>> Add support for basic NUMA awareness

> dogfish is a little bit upset it seems.

Hm, but why isn't anything else?

I noticed this a little further up in dogfish's log:

ninja: bad depfile: expected ':', saw 's'

I wonder if there's something a bit wrong with dogfish's meson
and/or ninja versions.

> Looking at pg_numa.c, shouldn't the include of postgres.h have an #ifndef
> FRONTEND guard for postgres_fe.h as well?

No, because it's evidently backend-only code.  The real question
is why is it in src/port/, because everything there gets built
for both frontend and backend.

			regards, tom lane