From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-committers@lists.postgresql.org,
 Daniel Gustafsson <daniel@yesql.se>,
        Tomas Vondra <tomas.vondra@postgresql.org>
Subject: Re: pgsql: Add support for basic NUMA awareness
In-reply-to: <87592CF0-5F4E-4043-BC57-E635E0924995@anarazel.de>
References: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
 <7ABC1680-3B82-4DD4-B9B7-BB4F74668B1A@yesql.se>
 <3976705.1744121148@sss.pgh.pa.us>
 <87592CF0-5F4E-4043-BC57-E635E0924995@anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 08 Apr 2025 10:24:21 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3979922.1744122992.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 08 Apr 2025 10:36:32 -0400
Message-ID: <3979923.1744122992@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3979923.1744122992%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On April 8, 2025 10:05:48 AM EDT, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I noticed this a little further up in dogfish's log:
>> =

>> ninja: bad depfile: expected ':', saw 's'

> I noticed that too - but it happened even before the hard failures. Will=
 look at it in a bit.

After catching up on the hackers thread, I wondered if this isn't
actually part of the identical issue, that is ninja is noticing
that there's not a dependency leading to that include file.

> I think part of the file would make sense to eventually use in FE code, =
we should move the SQL function and the page size function out. =


Works for me.  But a file in src/port/ should really use only c.h
if at all possible.  Otherwise (as Andrew said) it has to choose
one of postgres.h and postgres_fe.h depending on FRONTEND.

			regards, tom lane