Feedback-ID: ie0a040ee:Fastmail
Message-ID: <397fa815-c0cc-4531-9d09-0be3cc72c59a@eisentraut.org>
Date: Thu, 15 Jan 2026 10:36:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Enable Python Limited API for PL/Python on MSVC
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org,
 Andrew Dunstan <andrew@dunslane.net>, Bryan Green <dbryan.green@gmail.com>
References: <E1vfxZ0-000P6X-0h@gemulon.postgresql.org>
Content-Language: en-US
In-Reply-To: <E1vfxZ0-000P6X-0h@gemulon.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/397fa815-c0cc-4531-9d09-0be3cc72c59a%40eisentraut.org>
Precedence: bulk

This is failing on buildfarm member drongo: 
<https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=drongo&br=master>. 
  AFAICT, this is the only buildfarm member that tests Python on 
Windows, so we have no additional results to compare with.  It did pass 
on Cirrus CI.  Andrew/Bryan, could you figure out how the Python 
installation on drongo is different?


On 14.01.26 10:53, Peter Eisentraut wrote:
> Enable Python Limited API for PL/Python on MSVC
> 
> Previously, the Python Limited API was disabled on MSVC due to build
> failures caused by Meson not knowing to link against python3.lib
> instead of python3XX.lib when using the Limited API.
> 
> This commit works around the Meson limitation by explicitly finding
> and linking against python3.lib on MSVC, and removes the preprocessor
> guard that was disabling the Limited API on MSVC in plpython.h.
> 
> This requires python3.lib to be present in the Python installation,
> which is included when Python is installed.
> 
> Author: Bryan Green <dbryan.green@gmail.com>
> Discussion: https://www.postgresql.org/message-id/flat/ee410de1-1e0b-4770-b125-eeefd4726a24%40eisentraut.org
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/2bc60f86219b00a9ba23efab8f4bb8de21e64e2a
> 
> Modified Files
> --------------
> meson.build                | 16 +++++++++++++++-
> src/pl/plpython/plpython.h |  4 ----
> 2 files changed, 15 insertions(+), 5 deletions(-)
>