Content-Type: multipart/mixed; boundary="------------SjwsQnkpJ0ZvWsM0rZr6SNLe"
Message-ID: <39ac724e-58c8-4661-9e88-cb4ee97cb00e@gmail.com>
Date: Tue, 22 Jul 2025 14:30:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Log remote NOTICE, WARNING, and similar messages using
 ereport()
To: Fujii Masao <fujii@postgresql.org>, pgsql-committers@lists.postgresql.org
References: <E1ue5Sg-0008kc-0D@gemulon.postgresql.org>
Content-Language: en-US
From: Andrei Lepikhov <lepihov@gmail.com>
In-Reply-To: <E1ue5Sg-0008kc-0D@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/39ac724e-58c8-4661-9e88-cb4ee97cb00e%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------SjwsQnkpJ0ZvWsM0rZr6SNLe
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 22/7/2025 07:22, Fujii Masao wrote:
> Log remote NOTICE, WARNING, and similar messages using ereport().
> 
> Previously, NOTICE, WARNING, and similar messages received from remote
> servers over replication, postgres_fdw, or dblink connections were printed
> directly to stderr on the local server (e.g., the subscriber). As a result,
> these messages lacked log prefixes (e.g., timestamp), making them harder
> to trace and correlate with other log entries.
> 
> This commit addresses the issue by introducing a custom notice receiver
> for replication, postgres_fdw, and dblink connections. These messages
> are now logged via ereport(), ensuring they appear in the logs with proper
> formatting and context, which improves clarity and aids in debugging.
Perhaps I'm wrong, but it seems to me that you also need to add the 
libintl link to the Makefile of each module that uses the 
libpqsrv_notice_receiver routine.
At least, without this patch, I can't build master under MacOS:

Undefined symbols for architecture x86_64:
   "_libintl_gettext", referenced from:
       _libpqsrv_notice_receiver in dblink.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see 
invocation)

-- 
regards, Andrei Lepikhov
--------------SjwsQnkpJ0ZvWsM0rZr6SNLe
Content-Type: text/plain; charset=UTF-8;
 name="v0-0001-Fix-Makefile-in-modules-employing-the-libpqsrv_no.patch"
Content-Disposition: attachment;
 filename*0="v0-0001-Fix-Makefile-in-modules-employing-the-libpqsrv_no.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA2YTU3Nzg2MGMwYTdlYWFkZDQzZDkzMWY3MzdmZjVmMmE5NTRiNTk3IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiQW5kcmVpIFYuIExlcGlraG92IiA8bGVwaWhvdkBn
bWFpbC5jb20+CkRhdGU6IFR1ZSwgMjIgSnVsIDIwMjUgMTQ6MjU6NDggKzAyMDAKU3ViamVj
dDogW1BBVENIIHYwXSBGaXggTWFrZWZpbGUgaW4gbW9kdWxlcyBlbXBsb3lpbmcgdGhlCiBs
aWJwcXNydl9ub3RpY2VfcmVjZWl2ZXIgZnVuY3Rpb24KCi0tLQogY29udHJpYi9kYmxpbmsv
TWFrZWZpbGUgICAgICAgfCAxICsKIGNvbnRyaWIvcG9zdGdyZXNfZmR3L01ha2VmaWxlIHwg
MSArCiAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2Nv
bnRyaWIvZGJsaW5rL01ha2VmaWxlIGIvY29udHJpYi9kYmxpbmsvTWFrZWZpbGUKaW5kZXgg
ZmRlMGI0OWRkYmIuLmVhNjM5NmJjNzBjIDEwMDY0NAotLS0gYS9jb250cmliL2RibGluay9N
YWtlZmlsZQorKysgYi9jb250cmliL2RibGluay9NYWtlZmlsZQpAQCAtNiw2ICs2LDcgQEAg
T0JKUyA9IFwKIAlkYmxpbmsubwogUEdfQ1BQRkxBR1MgPSAtSSQobGlicHFfc3JjZGlyKQog
U0hMSUJfTElOS19JTlRFUk5BTCA9ICQobGlicHEpCitTSExJQl9MSU5LID0gJChmaWx0ZXIg
LWxpbnRsLCAkKExJQlMpKQogCiBFWFRFTlNJT04gPSBkYmxpbmsKIERBVEEgPSBkYmxpbmst
LTEuMi5zcWwgZGJsaW5rLS0xLjEtLTEuMi5zcWwgZGJsaW5rLS0xLjAtLTEuMS5zcWwKZGlm
ZiAtLWdpdCBhL2NvbnRyaWIvcG9zdGdyZXNfZmR3L01ha2VmaWxlIGIvY29udHJpYi9wb3N0
Z3Jlc19mZHcvTWFrZWZpbGUKaW5kZXggYWRmYmQyZWY3NTguLmJiYTI1NTFkZjUxIDEwMDY0
NAotLS0gYS9jb250cmliL3Bvc3RncmVzX2Zkdy9NYWtlZmlsZQorKysgYi9jb250cmliL3Bv
c3RncmVzX2Zkdy9NYWtlZmlsZQpAQCAtMTIsNiArMTIsNyBAQCBQR0ZJTEVERVNDID0gInBv
c3RncmVzX2ZkdyAtIGZvcmVpZ24gZGF0YSB3cmFwcGVyIGZvciBQb3N0Z3JlU1FMIgogCiBQ
R19DUFBGTEFHUyA9IC1JJChsaWJwcV9zcmNkaXIpCiBTSExJQl9MSU5LX0lOVEVSTkFMID0g
JChsaWJwcSkKK1NITElCX0xJTksgPSAkKGZpbHRlciAtbGludGwsICQoTElCUykpCiAKIEVY
VEVOU0lPTiA9IHBvc3RncmVzX2ZkdwogREFUQSA9IHBvc3RncmVzX2Zkdy0tMS4wLnNxbCBw
b3N0Z3Jlc19mZHctLTEuMC0tMS4xLnNxbCBwb3N0Z3Jlc19mZHctLTEuMS0tMS4yLnNxbAot
LSAKMi41MC4xCgo=

--------------SjwsQnkpJ0ZvWsM0rZr6SNLe--