Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_CE86B8B0-D68C-4E64-9B35-7EF5C7AF854D";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\))
Subject: Re: extension_control_path and "directory"
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: <aAjwPjsIElh17Nby@msg.df7cb.de>
Date: Wed, 23 Apr 2025 09:57:46 -0400
Cc: Matheus Alcantara <matheusssilv97@gmail.com>,
 Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers@lists.postgresql.org
Message-Id: <3C304C9E-976C-4FB9-A883-707E0B90756A@justatheory.com>
References: <E1tumbY-003Dl3-2o@gemulon.postgresql.org>
 <aAi1VACxhjMhjFnb@msg.df7cb.de>
 <CAFY6G8dDjimxaSQV68ExWMmrAi8xNhiOT3RZOD8oQZmdGCG5Jg@mail.gmail.com>
 <aAjwPjsIElh17Nby@msg.df7cb.de>
To: Christoph Berg <myon@debian.org>
Archived-At: 
 <https://www.postgresql.org/message-id/3C304C9E-976C-4FB9-A883-707E0B90756A%40justatheory.com>
Precedence: bulk


--Apple-Mail=_CE86B8B0-D68C-4E64-9B35-7EF5C7AF854D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On Apr 23, 2025, at 09:50, Christoph Berg <myon@debian.org> wrote:

> Remembering which path the .control file was found in and from there
> open the extension "directory" doesn't sound too hard. Why does it
> have to be more complicated?

This was my question, as well. Do you have a WIP patch to share, =
Matheus?

> Also, re-running a search path discovery for the directory is probably
> just wrong, if there are different extension versions in the "control"
> search path and the "extensions" search path, it might lead to weird
> version skew problems.

I assumed we would just have one or the other GUCs, not both.

> The number of extensions using that feature is limited, though, so it
> wouldn't be a huge problem:

FWIW it=E2=80=99s a a simple patch to make semver work, and probably =
also for the others. It=E2=80=99s just the reverse of this change[1]:

```patch
--- a/Makefile
+++ b/Makefile
@@ -5,7 +5,6 @@ EXTVERSION   =3D $(shell grep -m 1 =
'[[:space:]]\{8\}"version":' META.json | \
 DISTVERSION  =3D $(shell grep -m 1 '[[:space:]]\{3\}"version":' =
META.json | \
                sed -e =
's/[[:space:]]*"version":[[:space:]]*"\([^"]*\)",\{0,1\}/\1/')
  -MODULEDIR    =3D semver
 DATA         =3D $(wildcard sql/*.sql)
 DOCS         =3D $(wildcard doc/*.mmd)
 TESTS        =3D $(wildcard test/sql/*.sql)
--- a/semver.control
+++ b/semver.control
@@ -1,7 +1,5 @@
 # semver extension
 comment =3D 'Semantic version data type'
 default_version =3D '0.32.1'
-
-directory =3D 'semver'
 module_pathname =3D '$libdir/semver'
 relocatable =3D true

```

I think I=E2=80=99ll write a blog post this week recommending people not =
use these directives, and also to remove `$lib/` from `module_pathname`.

Best,

David

[1]: https://github.com/theory/pg-semver/commit/88b3abd


--Apple-Mail=_CE86B8B0-D68C-4E64-9B35-7EF5C7AF854D
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmgI8doACgkQkt9idPjI
gfHUGw//VldJaLhtWhgng7vJviq8+4qlXBM4bgG1232hDQdyNRrX+FyYxnZgY1C1
r17Nc6iVnVfNxbbWYILcUYYxl4bwKjXctLYh2MHItrQEsg0s5FSi1Z3uXhlXRe5z
ZVBE6exs7ocHAzekfWcldEzfyfDYgqdkJ/EEvWmPN9qR46NeOo6bSODRF5SQrg3i
jbR+XVg5D9fh4EIv3FCqJAtnFmuIM9oWdD8UiXZfO4LevPg5Te0yCONgaVAUYrIz
DnF/UdbG1ZAXLgBxHY7O3Ub4/HabXTk3BBYHJJ6ZkTmfFRjz+guj+JwQIp7hx73Y
Cri2PavsuCurcivbPIuT9RrZyjatU6XAo+i4SmiZvUQpPf1YQ9l1O76u348AvAD+
jAISAP3SfZ9BA7Jl9ptP/VbiYQps3cTvu6TE2IVwQBEVCL8S0joWEkv8RFxsPi6h
s3/rCqYwtnROQzETPANaAtwx/kk8O12gMIdKQOsy+s57Kt42Cw12vGiodDTHkhJU
QFnxfiK+hHyHbIw+9jyKy7Njf2MNICQhCWLWQNJ1waXvDaEJUTczweZBkC9vn89c
CNyXBN/bitYUPQwjukZ+K0EYUon1gY3WtQIzhwAb/m/PRNYmuwCw6rIROpEVI9Uk
aqVB1NFwUr1i7IXk7NRS9YnloafjeSQnEYX1BroiDJWdbHRqQi8=
=O5Nn
-----END PGP SIGNATURE-----

--Apple-Mail=_CE86B8B0-D68C-4E64-9B35-7EF5C7AF854D--