public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andrew Dunstan <[email protected]>
To: Sami Imseih <[email protected]>
To: Tom Lane <[email protected]>
Cc: Jeff Davis <[email protected]>
Cc: Jeff Davis <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Trial fix for old cross-version upgrades.
Date: Fri, 28 Feb 2025 14:48:41 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA5RZ0tz-AibaxVF1NnNMcMEmwut+kn=k=xG2XmDN9d6kv2-=g@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAA5RZ0u9dV3CdKqkqdusA_RdvBkwWe0c0rxcFWj++VYoutFYSw@mail.gmail.com>
	<[email protected]>
	<CAA5RZ0udD=7o6pjBSiEEzN60Jd3X1=vrXed+0YivYCVrqvav=Q@mail.gmail.com>
	<CAA5RZ0vgx8n98dcybr16V5mECEJRruBLMgDoVpmtpG+5D+5VPg@mail.gmail.com>
	<CAA5RZ0tz-AibaxVF1NnNMcMEmwut+kn=k=xG2XmDN9d6kv2-=g@mail.gmail.com>


On 2025-02-28 Fr 2:29 PM, Sami Imseih wrote:
> My perl expertise is bit shallow, but I could not find much
> regarding bugs related to such behavior, or maybe I did not
> look enough.
>
> Playing around with this, "s+", "s{1,}", s{2,}" all of these combinations
> where we are searching for more than 1 space result in the hanging command,
> but we really only need to look for a single space before the 'version',
> so maybe we can just do the below, which works?
>
> -       $dump =~ s {(^\s+'version',) '\d+'::integer,$}
> +      $dump =~ s {(^\s{1}'version',) '\d+'::integer,$}
>


Just noting here that \s{1} is simply the same as \s


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (30+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Trial fix for old cross-version upgrades.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox