Subject: Re: pgsql: Add support for temporary replication slots
To: Petr Jelinek <petr.jelinek@2ndquadrant.com>,
 Andres Freund <andres@anarazel.de>
References: <27274.1481557380@sss.pgh.pa.us> <27833.1481558144@sss.pgh.pa.us>
 <62935e6f-4f1b-c433-e0fa-7f936a38b3e5@2ndquadrant.com>
 <22907.1481571177@sss.pgh.pa.us> <15713.1481585953@sss.pgh.pa.us>
 <314cae39-2e7d-f5a3-d226-cfb80cf80481@2ndquadrant.com>
 <18684.1481589637@sss.pgh.pa.us>
 <48b2c017-695d-b5ac-2ff4-89b939b3e8f9@2ndquadrant.com>
 <20161213004903.iito2pefdrrjgny5@alap3.anarazel.de>
 <6886c56a-f6c8-3c44-53a1-dae6c24afb76@2ndquadrant.com>
 <20161213010059.dn64rrb3u7zxnnwk@alap3.anarazel.de>
 <a6b63bc4-ed38-2908-ef8d-1d96f2012d57@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@postgresql.org
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <3c8c413d-b476-93d2-652f-011a589a2d74@2ndquadrant.com>
Date: Wed, 14 Dec 2016 09:35:23 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <a6b63bc4-ed38-2908-ef8d-1d96f2012d57@2ndquadrant.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

On 12/12/16 8:28 PM, Petr Jelinek wrote:
> On 13/12/16 02:00, Andres Freund wrote:
>> On 2016-12-13 01:57:01 +0100, Petr Jelinek wrote:
>>> I mentioned that as possible solution upthread, I am only worried that
>>> the failure scenario is basically infinite loop.
>>
>> I don't see the problem with that. If you're really concerned you can
>> set a statement timeout.
>>
> 
> Okay in case we decide it's the right way to go attached patch does
> that. I also added some more tests based on your feedback while I am at it.

This looks mostly reasonable to me, but the location and xid output from
pg_logical_slot_get_changes() is not portable/repeatable, so it should
be omitted from the output.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers