Content-Type: multipart/alternative;
 boundary="------------yGNn50QjQrG656Qz5VIxpqfy"
Message-ID: <3fd6f7da-0453-4dde-95df-146fecfa7a92@dunslane.net>
Date: Sat, 12 Apr 2025 14:33:35 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Fix fat fingering in 22cb6d28950
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
References: <E1u310K-003f8j-2r@gemulon.postgresql.org>
 <CAKYtNAoQaLLreOzwvad2HBJUrCgRugxpUNKnF5Obzp0HhoGH8w@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: 
 <CAKYtNAoQaLLreOzwvad2HBJUrCgRugxpUNKnF5Obzp0HhoGH8w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/3fd6f7da-0453-4dde-95df-146fecfa7a92%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------yGNn50QjQrG656Qz5VIxpqfy
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2025-04-11 Fr 3:24 PM, Mahendra Singh Thalor wrote:
> On Fri, 11 Apr 2025 at 04:38, Andrew Dunstan <andrew@dunslane.net> wrote:
> >
> > Fix fat fingering in 22cb6d28950
> >
> > Per Rainier Vilela
> >
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> > 
> https://git.postgresql.org/pg/commitdiff/39729ec01d25dbe12e0dd8322c68f242650235c9
> >
> > Modified Files
> > --------------
> > src/bin/pg_dump/pg_restore.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> Hi,
> This seems not a proper fix, rather this is adding a segfault.
>
[...]

> Here, we are passing &q, but we can't free this by destroyStringInfo(&q);
>
> *Fix*: pg_free(q.data)


Quite right. Clearly I was not having a good day on Thursday. Will fix.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------yGNn50QjQrG656Qz5VIxpqfy
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2025-04-11 Fr 3:24 PM, Mahendra
      Singh Thalor wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAKYtNAoQaLLreOzwvad2HBJUrCgRugxpUNKnF5Obzp0HhoGH8w@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">On Fri, 11 Apr 2025 at 04:38, Andrew Dunstan &lt;<a
          href="mailto:andrew@dunslane.net" moz-do-not-send="true"
          class="moz-txt-link-freetext">andrew@dunslane.net</a>&gt;
        wrote:<br>
        &gt;<br>
        &gt; Fix fat fingering in 22cb6d28950<br>
        &gt;<br>
        &gt; Per Rainier Vilela<br>
        &gt;<br>
        &gt; Branch<br>
        &gt; ------<br>
        &gt; master<br>
        &gt;<br>
        &gt; Details<br>
        &gt; -------<br>
        &gt; <a
href="https://git.postgresql.org/pg/commitdiff/39729ec01d25dbe12e0dd8322c68f242650235c9"
          moz-do-not-send="true" class="moz-txt-link-freetext">https://git.postgresql.org/pg/commitdiff/39729ec01d25dbe12e0dd8322c68f242650235c9</a><br>
        &gt;<br>
        &gt; Modified Files<br>
        &gt; --------------<br>
        &gt; src/bin/pg_dump/pg_restore.c | 4 ++--<br>
        &gt; 1 file changed, 2 insertions(+), 2 deletions(-)<br>
        &gt;<br>
        <br>
        Hi,<br>
        This seems not a proper fix, rather this is adding a segfault.<br>
        <br>
      </div>
    </blockquote>
    <div dir="ltr">[...]<br>
    </div>
    <br>
    <blockquote type="cite"
cite="mid:CAKYtNAoQaLLreOzwvad2HBJUrCgRugxpUNKnF5Obzp0HhoGH8w@mail.gmail.com">
      <div dir="ltr">
        <div>Here, we are passing &amp;q, but we can't free this by
          destroyStringInfo(&amp;q); </div>
        <div><br>
        </div>
        <div><b>Fix</b>: pg_free(q.data)</div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>Quite right. Clearly I was not having a good day on Thursday.
      Will fix.</p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------yGNn50QjQrG656Qz5VIxpqfy--