Feedback-ID: ie0a040ee:Fastmail
Message-ID: <3ff35999-7a1e-40fa-938c-f2bff85e2e2f@eisentraut.org>
Date: Mon, 16 Mar 2026 11:42:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons
 from procsignals)
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Andres Freund <andres@anarazel.de>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <aYtcMg5hMdGdhX4q@alap3.anarazel.de>
 <1cb0d7e9-d6dd-4517-a7cd-0ad98e1207f3@iki.fi>
 <aYtsrQ-kmA8nqeiH@alap3.anarazel.de>
 <aYuDz2kvi7haNORb@ip-10-97-1-34.eu-west-3.compute.internal>
 <aYuIrKbh1kW36xbc@alap3.anarazel.de>
 <3dd6f70c-b94d-4428-8e75-74a7136396be@iki.fi>
 <aYwISFVCAJon5ZxT@ip-10-97-1-34.eu-west-3.compute.internal>
 <787be980-0878-4f4a-be01-d042ab5d370e@iki.fi>
 <aY7auF2/xuT58vRI@ip-10-97-1-34.eu-west-3.compute.internal>
 <d7a788fa-e609-4894-a8be-2f70e135424f@eisentraut.org>
 <aZ2LS5m1K2G3r3U4@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <aZ2LS5m1K2G3r3U4@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/3ff35999-7a1e-40fa-938c-f2bff85e2e2f%40eisentraut.org>
Precedence: bulk

On 24.02.26 12:28, Bertrand Drouvot wrote:
>> You can/should use C11 standard alignas(), so you don't need to worry about
>> whether it's supported or not.
> 
> Oh right, I did not notice 300c8f53247 and following like e7075a3405c, d4c0f91f7d5
> and 97e04c74bed.
> 
> PFA, 0001 doing so for PGPROC and PgAioUringContext. As those are typedef,
> the patch puts alignas within the struct.
> 
> For PGPROC at the start of the struct, I think that placing it on the first member
> is the right location because it ensures the whole struct is aligned to PG_CACHE_LINE_SIZE
> without adding padding before this member. For example if I set it on backendType,
> then it adds 100 bytes of padding and the struct is obviously still a multiple of
> PG_CACHE_LINE_SIZE but is now 1024 bytes (instead of 896).
> 
> For PgAioUringContext at completion_lock (like suggested by Andres in [1]), which
> is also the start of the struct.
> 
> I checked and the padding for those are exactly the same after the changes.

I have committed the 0001 patch.

> 0002, is also making use of alignas in ItemPointerData, but this one is more
> tricky so I'm not sure that's worth it (given the fact that we still need to
> keep pg_attribute_aligned() as explained by Peter in [2]).

This doesn't seem worth it to me.  Let's skip it.