Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vuxUo-00EbCx-2S
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 24 Feb 2026 18:50:58 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vuxUl-002w6r-1l
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 24 Feb 2026 18:50:55 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vuxUl-002w6i-0q
	for pgsql-hackers@lists.postgresql.org;
	Tue, 24 Feb 2026 18:50:55 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vuxUd-0000000167t-099v
	for pgsql-hackers@lists.postgresql.org;
	Tue, 24 Feb 2026 18:50:50 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 61OIoXLp4004007;
	Tue, 24 Feb 2026 13:50:33 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jacob.champion@enterprisedb.com>
cc: Jelte Fennema-Nio <postgres@jeltef.nl>,
 pgsql-hackers@lists.postgresql.org,
        Andrew Dunstan <andrew@dunslane.net>,
        Nathan Bossart <nathandbossart@gmail.com>
Subject: Re: pgsql: libpq: Grease the protocol by default
In-reply-to: 
 <CAOYmi+=6AFrYm5LaPc=ECyLp2uh1-Y8xLA-dRBJE82JLRdiQ5g@mail.gmail.com>
References: <E1vub8B-000rlS-05@gemulon.postgresql.org>
 <CAOYmi+=4QhCjssfNEoZVK8LPtWxnfkwT5p-PAeoxtG9gpNjqOQ@mail.gmail.com>
 <3626145.1771885089@sss.pgh.pa.us>
 <CAOYmi+k8ENYkErqSEYEqW39YWPfe_ii7g5Acm1c9asNuRMriNg@mail.gmail.com>
 <3635497.1771889682@sss.pgh.pa.us>
 <CAOYmi+mtFBsB2zePSvbpa-2Zb-+V5bov_t2BzkGH7vfKX0ny_w@mail.gmail.com>
 <3797860.1771893905@sss.pgh.pa.us>
 <CAOYmi+kC3AN0QJKT0OunHCmi4UU7-15eu7w-DY5ckOgHiQE1QA@mail.gmail.com>
 <3864574.1771898936@sss.pgh.pa.us>
 <CAOYmi+=96EGcQnY2w99yLeARHsbvgT_2Bv1hjXKUziykMzMhtA@mail.gmail.com>
 <CAOYmi+=6AFrYm5LaPc=ECyLp2uh1-Y8xLA-dRBJE82JLRdiQ5g@mail.gmail.com>
Comments: In-reply-to Jacob Champion <jacob.champion@enterprisedb.com>
	message dated "Tue, 24 Feb 2026 10:13:02 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4004005.1771959033.1@sss.pgh.pa.us>
Date: Tue, 24 Feb 2026 13:50:33 -0500
Message-ID: <4004006.1771959033@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/4004006.1771959033%40sss.pgh.pa.us>
Precedence: bulk

Jacob Champion <jacob.champion@enterprisedb.com> writes:
> So pg_upgrade will use max_protocol_version=3.0 with all servers v10
> and below, in practice. There's nothing wrong with that behavior, but
> I think I should switch to a simple `< 1100` check in the code to
> avoid misleading people, unless anyone has a better way that won't
> significantly increase the cost of the backport.

Simple is good here.  I don't think we'd buy much by distinguishing
minor versions of already-EOL servers.  Also, I suspect that
pg_upgrade can't get the minor version except by starting the server
and asking it --- we don't record anything but major version on-disk.

			regards, tom lane