From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Generate syscache info from catalog files
In-reply-to: <E1rSAY2-002hIk-4y@gemulon.postgresql.org>
References: <E1rSAY2-002hIk-4y@gemulon.postgresql.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Tue, 23 Jan 2024 06:46:14 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4020890.1706018887.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 23 Jan 2024 09:08:07 -0500
Message-ID: <4020891.1706018887@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/4020891.1706018887%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> Generate syscache info from catalog files

Per guaibasaurus[1], this commit broke "make dist":

...
rm -rf tmp_install/ portlock/
rm -f config.cache config.log config.status GNUmakefile
make[1]: Leaving directory '/home/pgsql/buildfarm/buildroot/HEAD/pgsql.bui=
ld/postgresql-17devel'
/bin/tar chf postgresql-17devel.tar postgresql-17devel
/bin/tar: postgresql-17devel/src/include/catalog/syscache_ids.h: File remo=
ved before we read it
/bin/tar: postgresql-17devel/src/include/catalog/syscache_info.h: File rem=
oved before we read it
make: *** [GNUmakefile:94: postgresql-17devel.tar] Error 1
make: *** Deleting file 'postgresql-17devel.tar'

I'm not sure why --- the makefile changes treat these new files
exactly like other generated files.  It doesn't repro here,
either, which is odd.  It looks like a timing problem, but how
could there be one?

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dguaibasaurus=
&dt=3D2024-01-23%2012%3A20%3A03