Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSJlM-00Cvbg-Ep for pgsql-committers@arkaria.postgresql.org; Tue, 23 Jan 2024 16:36:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rSJlL-00EO4b-K5 for pgsql-committers@arkaria.postgresql.org; Tue, 23 Jan 2024 16:36:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSJlL-00EO4T-Cb for pgsql-committers@lists.postgresql.org; Tue, 23 Jan 2024 16:36:35 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSJlI-002zNg-W4 for pgsql-committers@lists.postgresql.org; Tue, 23 Jan 2024 16:36:34 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 40NGaUL24049176; Tue, 23 Jan 2024 11:36:30 -0500 From: Tom Lane To: Peter Eisentraut cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Generate syscache info from catalog files In-reply-to: References: <4020891.1706018887@sss.pgh.pa.us> Comments: In-reply-to Peter Eisentraut message dated "Tue, 23 Jan 2024 16:31:14 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4049174.1706027790.1@sss.pgh.pa.us> Date: Tue, 23 Jan 2024 11:36:30 -0500 Message-ID: <4049175.1706027790@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > On 23.01.24 15:08, Tom Lane wrote: >> Per guaibasaurus[1], this commit broke "make dist": >> I'm not sure why --- the makefile changes treat these new files >> exactly like other generated files. It doesn't repro here, >> either, which is odd. It looks like a timing problem, but how >> could there be one? > I have found that the files are not listed in the clean target in > src/include/Makefile. That might explain it, but it's gotta be fixed > anyway. I'll go ahead with that. Looks like that made guaibasaurus happy, but I'm still mystified as to what was wrong and why it didn't repro elsewhere. regards, tom lane