From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Robert Haas <robertmhaas@gmail.com>, Amit Kapila <akapila@postgresql.org>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Remove unused wait events.
In-reply-to: <1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se>
References: <E1mdOBY-0005j2-QL@gemulon.postgresql.org>
 <CA+TgmoYSAsxiHqpyDCzJa2-hYv0Sme7Me1esi6sHG6LbY8KD+w@mail.gmail.com>
 <4047667.1635179918@sss.pgh.pa.us>
 <CA+TgmoZ2W5Pqq19kzN5K-Boveq0u1v5az7wFJcUhHdZ18aw7_A@mail.gmail.com>
 <4050629.1635182306@sss.pgh.pa.us>
 <1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Mon, 25 Oct 2021 19:34:37 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4052152.1635183584.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 25 Oct 2021 13:39:44 -0400
Message-ID: <4052153.1635183584@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/4052153.1635183584%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> Since this will cause integer values to have different textual enum valu=
e
> representations in 14 and 15+, do we want to skip two numbers by assigni=
ng the
> next wait event the integer value of WAIT_EVENT_WAL_WRITE incremented by=
 three?
> Or enum integer reuse not something we guarantee against across major ve=
rsions?

We require a recompile across major versions.  I don't see a reason why
this particular enum needs more stability than any other one.

			regards, tom lane