Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZX35-005l2Y-EX for pgsql-committers@arkaria.postgresql.org; Fri, 25 Aug 2023 13:40:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qZX34-003Id3-1Q for pgsql-committers@arkaria.postgresql.org; Fri, 25 Aug 2023 13:40:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZX33-003Icq-Pw for pgsql-committers@lists.postgresql.org; Fri, 25 Aug 2023 13:40:25 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZX2w-000yqA-9E for pgsql-committers@lists.postgresql.org; Fri, 25 Aug 2023 13:40:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 37PDeENj4126205; Fri, 25 Aug 2023 09:40:14 -0400 From: Tom Lane To: Andrew Dunstan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Cache by-reference missing values in a long lived context In-reply-to: <7a219b25-b71b-f3ab-5f60-072b65e03d0d@dunslane.net> References: <3907902.1692890821@sss.pgh.pa.us> <3979066.1692910679@sss.pgh.pa.us> <7a219b25-b71b-f3ab-5f60-072b65e03d0d@dunslane.net> Comments: In-reply-to Andrew Dunstan message dated "Fri, 25 Aug 2023 09:33:31 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4126203.1692970814.1@sss.pgh.pa.us> Date: Fri, 25 Aug 2023 09:40:14 -0400 Message-ID: <4126204.1692970814@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > On 2023-08-24 Th 16:57, Tom Lane wrote: >> I'm not sure if those arguments justify a back-patch instead of >> the localized hack you suggest. > Seems like overkill given the age of the surrounding code and the > nearness to EOL of releases 11 and 12. I agree that 11 is nearly dead, but 12 still has a year-plus to go. Another point that I wasn't thinking of yesterday is that 11 is still expected to compile on pre-C99 compilers. I'm not sure to what extent we are still able to test that -- my old animals have all gone to buildfarm heaven, although I see that Noah's AIX menagerie is still soldiering on. Were we relying on "{ 0 }" anywhere else pre-v12? regards, tom lane