Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYBmp-0000tc-8D for pgsql-committers@arkaria.postgresql.org; Wed, 06 Oct 2021 18:37:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYBmo-0005kE-7T for pgsql-committers@arkaria.postgresql.org; Wed, 06 Oct 2021 18:37:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYBmo-0005jo-1J for pgsql-committers@lists.postgresql.org; Wed, 06 Oct 2021 18:37:02 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYBml-0000jw-9P for pgsql-committers@lists.postgresql.org; Wed, 06 Oct 2021 18:37:01 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 196IauCb4159892; Wed, 6 Oct 2021 14:36:57 -0400 From: Tom Lane To: Andrey Borodin cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Avoid doing catalog lookups in postgres_fdw's conversion_error_c In-reply-to: References: <08916396-55E4-4D68-AB3A-BD6066F9E5C0@yandex-team.ru> <4084181.1633460892@sss.pgh.pa.us> Comments: In-reply-to Andrey Borodin message dated "Tue, 05 Oct 2021 22:13:34 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <4159890.1633545416.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 06 Oct 2021 14:36:56 -0400 Message-ID: <4159891.1633545416@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrey Borodin writes: > 5 =D0=BE=D0=BA=D1=82. 2021 =D0=B3., =D0=B2 22:08, Tom Lane =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >> Could we have a test case for that please? It seems to be related >> to ANALYZE, but I'm unexcited about reverse-engineering the details. > Sure, I'll compose a repro a bit later. Ah, never mind, I found I can duplicate it just by adding an ANALYZE in the stanza of postgres_fdw.sql that's already checking for conversion-error cases. Will fix. regards, tom lane