Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkxPg-0005KV-Nb for pgsql-committers@arkaria.postgresql.org; Wed, 01 Aug 2018 20:08:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fkxPd-0004ig-AB for pgsql-committers@arkaria.postgresql.org; Wed, 01 Aug 2018 20:08:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkxPd-0004iZ-5J for pgsql-committers@lists.postgresql.org; Wed, 01 Aug 2018 20:08:01 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkxPZ-0007GN-Jg; Wed, 01 Aug 2018 20:08:00 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w71K7sN5004167; Wed, 1 Aug 2018 16:07:54 -0400 From: Tom Lane To: Thomas Munro cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Use signals for postmaster death on Linux. In-reply-to: References: Comments: In-reply-to Thomas Munro message dated "Wed, 11 Jul 2018 01:14:52 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4165.1533154074.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 01 Aug 2018 16:07:54 -0400 Message-ID: <4166.1533154074@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Thomas Munro writes: > Use signals for postmaster death on Linux. One or the other of these patches seems to have caused pmsignal.h to fail to compile standalone: ./src/include/storage/pmsignal.h:79: error: expected '=3D', ',', ';', 'asm= ' or '__attribute__' before 'postmaster_possibly_dead' ./src/include/storage/pmsignal.h: In function 'PostmasterIsAlive': ./src/include/storage/pmsignal.h:84: error: 'postmaster_possibly_dead' und= eclared (first use in this function) ./src/include/storage/pmsignal.h:84: error: (Each undeclared identifier is= reported only once ./src/include/storage/pmsignal.h:84: error: for each function it appears i= n.) Apparently, this header needs a reference to wherever sig_atomic_t is declared. regards, tom lane