Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0dPa-006uAM-KH for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Nov 2023 07:55:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r0dPY-000Laz-Ic for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Nov 2023 07:55:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0dPX-000Laq-Hr for pgsql-hackers@lists.postgresql.org; Wed, 08 Nov 2023 07:55:40 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0dPU-004Wng-Oi for pgsql-hackers@postgresql.org; Wed, 08 Nov 2023 07:55:38 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id BCCF03200A03; Wed, 8 Nov 2023 02:55:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 08 Nov 2023 02:55:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm2; t=1699430134; x=1699516534; bh=o+5gC59YzBtDC4D/3OdPVS/Xc 2WvjR1WsxsIhA/O1og=; b=S0aBUTzVa0yX743CHU/uSdP0cvRzW6SgmIbViwmRu RksTFHF6DqHLOn7DMKwRwgbW3Ou47U6wwitbWmrZMB1VlHKBdCrtf88cndbdvWZF kx5PxOTE3hHzf7BLam+mHeVfC2Urn+GgEYtH7lo7SLx2yAcwSDa7EDutfhse8qwp Ll7T6cO7P4GWW1QzNXGAtgKMQJGOZ8Iiy8GpHjI6E1JJYEcJ25LkHYR8xfwAkomp bCq3yFcWwsstnDUZh381yrqy9ZLzGtCH4MoRwfziXL3YOb2OfINNcw7H1xI1WhPP OBvTYIvox70GAmN+5wegokSWQxTx97P3Jj03VSnC7Ychg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699430134; x=1699516534; bh=o+5gC59YzBtDC4D/3OdPVS/Xc2WvjR1Wsxs IhA/O1og=; b=IOBhx963lmC3Qks+BFfbjhpyKw8I2jgyiuL3QjrmmTSU+UiXY/Y X/NdDSXlrkmG5hoBu/S+yVLvIHrjjwiHH66V0zH+McerFYD1qXIlEy3SVn8uAh4A fdPVkQtWu4zTqiYo7Sf6EeBNX7jJHBa0fr4zmxW61+TXB3M1qsdEXXEu2LKw3fRk ZQYEKwskl+wuFmyVxuNxFFJNoaEWcBu0O54u89kFy7NBgnv2+p31+kQQ6JAxz6Ng sGOC+9jHKDKvl0yUYD2Lrry3+RBvNEc7ZeeLg1tdhmqYB3vRZ739FIzcnhNkKUb0 SUhceLAvs8TQ0mtVtiR0bB2YmjMvnI3mDpQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddukedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomheprfgv thgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhesvghishgvnhhtrhgruhhtrdhorh hgqeenucggtffrrghtthgvrhhnpefgjedthfekfedtuefgieelheetleejgefhueeltdfh ueetvdffudekfeejhfegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Nov 2023 02:55:33 -0500 (EST) Message-ID: <41dba437-5622-4ae0-a6bb-726da8771584@eisentraut.org> Date: Wed, 8 Nov 2023 08:55:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Clean up role created in new subscription test. Content-Language: en-US To: Daniel Gustafsson , Tom Lane Cc: Robert Haas , PostgreSQL Hackers References: <267900.1680201870@sss.pgh.pa.us> <99112997-6732-42C7-989B-06406C911FE2@yesql.se> <284965.1680208176@sss.pgh.pa.us> <0134C9EC-5F6B-4EAC-B2D5-BB4249BEBD4D@yesql.se> <3C83CEE2-0758-400C-979C-FD9E828C4709@yesql.se> <4447BBC5-26DA-4BDB-838B-50819E8E6EA7@yesql.se> From: Peter Eisentraut In-Reply-To: <4447BBC5-26DA-4BDB-838B-50819E8E6EA7@yesql.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 06.07.23 00:00, Daniel Gustafsson wrote: >> On 16 May 2023, at 11:17, Daniel Gustafsson wrote: > >> Parked in the July CF for now. > > Rebased to fix a trivial conflict highlighted by the CFBot. I think the problem with this approach is that one would need to reapply it to each regression test suite separately. For example, there are several tests under contrib/ that create roles. These would not be covered by this automatically. I think the earlier idea of just counting roles, tablespaces, etc. before and after would be sufficient.