Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUEiS-0008W9-AK for pgsql-committers@arkaria.postgresql.org; Tue, 15 Mar 2022 21:28:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nUEiR-0005zJ-7E for pgsql-committers@arkaria.postgresql.org; Tue, 15 Mar 2022 21:28:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUEiR-0005zA-0K for pgsql-committers@lists.postgresql.org; Tue, 15 Mar 2022 21:28:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUEiO-0001U4-Un for pgsql-committers@lists.postgresql.org; Tue, 15 Mar 2022 21:28:26 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22FLSNmn428076; Tue, 15 Mar 2022 17:28:23 -0400 From: Tom Lane To: David Steele cc: Thomas Munro , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix pg_basebackup with in-place tablespaces. In-reply-to: <66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net> References: <66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net> Comments: In-reply-to David Steele message dated "Tue, 15 Mar 2022 14:40:35 -0600" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <428074.1647379703.1@sss.pgh.pa.us> Date: Tue, 15 Mar 2022 17:28:23 -0400 Message-ID: <428075.1647379703@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk David Steele writes: > On 3/14/22 19:31, Thomas Munro wrote: >> Fix pg_basebackup with in-place tablespaces. > Perhaps I'm being picky, but seems like this logic should be wrapped in: > if (allow_in_place_tablespaces) > { > <...> > } > I worry about strange effects when this GUC is not enabled. What would happen if someone created an in-place tablespace and then turned off the GUC? regards, tom lane