Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUVOc-0005fG-IH for pgsql-committers@arkaria.postgresql.org; Thu, 08 Apr 2021 14:12:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lUVOb-0004HO-Bv for pgsql-committers@arkaria.postgresql.org; Thu, 08 Apr 2021 14:12:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUVOb-0004EI-6H for pgsql-committers@lists.postgresql.org; Thu, 08 Apr 2021 14:12:33 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUVOW-00066J-M4 for pgsql-committers@lists.postgresql.org; Thu, 08 Apr 2021 14:12:32 +0000 X-Originating-IP: 99.10.92.30 Received: from [192.168.10.146] (99-10-92-30.lightspeed.rlghnc.sbcglobal.net [99.10.92.30]) (Authenticated sender: adsend@dunslane.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id ECF024000D; Thu, 8 Apr 2021 14:12:24 +0000 (UTC) Subject: Re: pgsql: SQL-standard function body To: Andres Freund , David Rowley Cc: Tom Lane , Peter Eisentraut , pgsql-committers@lists.postgresql.org References: <20210407225806.majgznh4lk34hjvu@alap3.anarazel.de> <1730972.1617836766@sss.pgh.pa.us> <20210408015017.yb2tb324y6zt4o66@alap3.anarazel.de> From: Andrew Dunstan Message-ID: <42affe76-48c4-a78c-e548-83a16b806af2@dunslane.net> Date: Thu, 8 Apr 2021 10:12:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210408015017.yb2tb324y6zt4o66@alap3.anarazel.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 4/7/21 9:50 PM, Andres Freund wrote: > Hi, > > On 2021-04-08 13:33:18 +1200, David Rowley wrote: >> On Thu, 8 Apr 2021 at 11:06, Tom Lane wrote: >>> Andres Freund writes: >>> >>>> Might be force_parallel_mode=regress related. >>> Yeah. On my machine, it's fine without force_parallel_mode and >>> crashes with that. Looks like query text is not getting passed >>> to the parallel worker in some cases. >> I wonder if it would be worth adding a regression test run of the core >> tests during make check-world with force_parallel_mode set to regress. >> >> But maybe people running the tests on slow machines might not be a fan >> of that idea. > I've wondered about that too. Perhaps we could reuse the pg_upgrade run? > Honestly I'd prefer it if we could get rid of the rerun of 'make check' by pg_upgrade's test.sh and instead upgrade the data directory made by the earlier 'make check' run if it's still there (which would mean we'd need to stop it being deleted). cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com