Message-ID: <431478bb-d8c7-7cc0-63cf-2ad2925ef721@dunslane.net>
Date: Thu, 9 Dec 2021 08:59:08 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@lists.postgresql.org
References: <E1muynv-0006GS-R4@gemulon.postgresql.org>
 <3655283.1638977975@sss.pgh.pa.us>
 <2e118a11-6936-21ec-6782-e9dbb20972c2@dunslane.net>
 <3657697.1638980149@sss.pgh.pa.us>
 <b179201e-8451-6a5e-e9be-9c755a13be7f@dunslane.net>
 <3660797.1638983124@sss.pgh.pa.us>
 <b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
 <20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/431478bb-d8c7-7cc0-63cf-2ad2925ef721%40dunslane.net>
Precedence: bulk


On 12/8/21 21:16, Andres Freund wrote:
> Hi,
>
> On 2021-12-08 12:53:29 -0500, Andrew Dunstan wrote:
>> It would have passed the test and failed the invocation as before. It
>> turns out that the tar being used is from the (old) MsysGit
>> installation. So I'm rearranging the path so it finds the system tar
>> instead. That should take care of things. (testing first before I do
>> anything else). On my initial test the system tar handled paths with
>> drive specs just fine.
> I just hit this issue. The tar included in a just-updated git-for-windows
> fails with "tar: Cannot connect to c: resolve failed".
>
> Git appears to install itself in front of c:\windows\system32 in PATH (which
> contains the system tar). Which I think means that after edc2332550 this will
> have to be manually addressed by most people running tests on windows
> manually? That doesn't seem great :(
>


I'm not sure how you're installing git, or even if you're installing it
at all  - maybe it comes with the image you're using. In my standard
Windows VM setup I just install git via chocolatey, and it only puts
git's cmd directory in the path, not the bin directory. This is a git
install option I know I've used in the past when installing manually.
(The setup where bowerbird runs is much older).


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com