From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
cc: Dean Rasheed <dean.a.rasheed@gmail.com>,
        Tomas Vondra <tomas.vondra@postgresql.org>,
        pgsql-committers@lists.postgresql.org,
        Fabien COELHO <coelho@cri.ensmp.fr>
Subject: Re: pgsql: Rework the pg_statistic_ext catalog
In-reply-to: <14081.1560693790@sss.pgh.pa.us>
References: <E1hcHz2-0005mY-5A@gemulon.postgresql.org>
 <8833.1560647898@sss.pgh.pa.us> <20156.1560650744@sss.pgh.pa.us>
 <CAEZATCWWX5O57d=MHY=MqyJe-xHG2pbi75LKLjo6aZLP3zsaow@mail.gmail.com>
 <20190616085651.d2hxuiqlojewed5j@development>
 <20190616100328.shl2hhuy2pup6ges@development>
 <20190616112021.2mncnuj26sbsbnzx@development>
 <14081.1560693790@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sun, 16 Jun 2019 10:03:10 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4351.1560698164.1@sss.pgh.pa.us>
Date: Sun, 16 Jun 2019 11:16:04 -0400
Message-ID: <4352.1560698164@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>> OK, it seems the buildfarm is getting green again. I'm not sure why I'm
>> seeing the failure in 011_crash_recovery.pl, while the buildfarm does
>> not. Perhaps my environment is borked in some way? Not sure.

> I see that Coelho's two bleeding-edge-clang animals are reporting that
> failure too.  Normally I'd just ignore those two; they break pretty
> regularly.  Maybe you're using an almost-bleeding-edge clang?

Oh --- I managed to reproduce that failure locally on RHEL6 (nothing
bleeding-edge anywhere), but it went away after make-clean-and-rebuild.
I'm suspicious that the underlying cause was failure to recompile
something that knows the value of CATALOG_VERSION_NO.

This theory is insufficient to explain why Coelho's animals failed,
though.  Maybe it would, if you also posit a ccache screwup?  But it's
not obvious from their configurations that they're using ccache at all.

			regards, tom lane