Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pahxB-0007BN-NX for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Mar 2023 18:58:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pahxA-00006K-Iv for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Mar 2023 18:58:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pahxA-00006B-5e for pgsql-hackers@lists.postgresql.org; Fri, 10 Mar 2023 18:58:56 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pahx6-0002nY-TI for pgsql-hackers@postgresql.org; Fri, 10 Mar 2023 18:58:55 +0000 Received: by mail-pj1-x1029.google.com with SMTP id qa18-20020a17090b4fd200b0023750b675f5so10840443pjb.3 for ; Fri, 10 Mar 2023 10:58:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; t=1678474731; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=dUh2LW/rAPVTEagL/8rrlB/18SrA8Wpcoap68R+wRao=; b=DqG2f3Qpv9M1aISrOu9PdRFhsO4k70du+cyUlyqAqTuV1Zp9Oga6PKuKn1UXTgasub Db7EOlPAVGLF/I6uqy0evYlWeXnKVqohXcxMbtgb9YlulwiXsSK/+KptRtOZGRisnieT DoKEXTetr89HLC3/mIbG+NlJGqIVbxCKYoB8UxGa9Qg6HALiD2id0cQfJzs7DD2/0ToX K94t64NYvfpFDbGv2haqDKfQi3eAo0fBxaXNvdhhAhF3bGgNypzML6leKD7pANrwEOBk HcQa2gmLWqf6yvNHOhqnrY8ToC4FIb+iz+nKjt+KIVzTS3qo/TmesoBPsWgCaibaqvY1 Qxaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678474731; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dUh2LW/rAPVTEagL/8rrlB/18SrA8Wpcoap68R+wRao=; b=nSqb27H+bv3h9nE8LbaREgAEsvy1DOx21VN91l5wK6gVJTNbBL7Afv1b5SEdMgPKUx qNgM1I1KPP2KPHOVp+uqTj8POsRLjpEJGOOZHl10dgHeP7etcr4gE+aw7jqYVss0ghyH zLO64VmwVlSMr6T2o5D3E8yym6hqeojpJmhN/I4MwJ+m6VOCoxHV61/8VQmGvbJhhHPc AdnwmRKLmNm5OBRaHBX2gBjWCp/J8IBuSosbIlIAbbi2UyqBFtKLHIzBZirT6OTCnwkN hQ87SH5rpIVKhED+ePBF0jmWke9uoAuhdvEKHzKHyCc/c9/rXA496h13mNvRcgcsmfD7 PVcw== X-Gm-Message-State: AO0yUKXGu3mPgW23lP90Y2DSPLem3nPLYJ341PucQ6C6wbrPLecE7ApP 9MrBOvz62WQKPMbbvGTrROnwAzxFW78uigIHGm8= X-Google-Smtp-Source: AK7set+4T9cs4WOFHIUv3wm3sZwahLjokaO+NlPsSs4AWhBI1DOlE3vXcDkx13ChFIBT03tGDaQ9kQ== X-Received: by 2002:a17:903:2290:b0:19e:25b4:7740 with SMTP id b16-20020a170903229000b0019e25b47740mr32452177plh.28.1678474730713; Fri, 10 Mar 2023 10:58:50 -0800 (PST) Received: from jeff-laptop.lan (c-73-231-146-4.hsd1.ca.comcast.net. [73.231.146.4]) by smtp.gmail.com with ESMTPSA id jx16-20020a170903139000b0019a8468cbe7sm308830plb.224.2023.03.10.10.58.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 10:58:50 -0800 (PST) Message-ID: <437cb29641d176ccfb9d631351582fdd96842d8d.camel@j-davis.com> Subject: Re: pgsql: Use ICU by default at initdb time. From: Jeff Davis To: Peter Eisentraut , pgsql-hackers Date: Fri, 10 Mar 2023 10:58:49 -0800 In-Reply-To: <238f8443506cce214979caa0fc3b06c5dbf99bc7.camel@j-davis.com> References: <238f8443506cce214979caa0fc3b06c5dbf99bc7.camel@j-davis.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, 2023-03-10 at 07:48 -0800, Jeff Davis wrote: > On Fri, 2023-03-10 at 15:48 +0100, Peter Eisentraut wrote: > > Yes, of course.=C2=A0 So we can't really do what I was thinking of. >=20 > OK, I plan to commit something like the patch in this thread soon. I > just need to add an explanatory comment. Committed a slightly narrower fix that derives the default encoding the same way for both libc and ICU; except that ICU still uses UTF-8 for C/POSIX/--no-locale (because ICU doesn't work with SQL_ASCII). That seemed more consistent with the comments around pg_get_encoding_from_locale() and it was also easier to document the -E switch in initdb. I'll keep an eye on the buildfarm to see if this fixes the problem or causes other issues. But it seems like the right change. Regards, Jeff Davis