Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nA0iw-0003rd-Db for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Jan 2022 02:29:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nA0iv-0003c0-AV for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Jan 2022 02:29:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nA0iv-0003br-1M for pgsql-hackers@lists.postgresql.org; Wed, 19 Jan 2022 02:29:21 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nA0is-0004Wp-VL for pgsql-hackers@lists.postgresql.org; Wed, 19 Jan 2022 02:29:20 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 20J2TGg3438734; Tue, 18 Jan 2022 21:29:16 -0500 From: Tom Lane To: Robert Haas cc: PostgreSQL Hackers Subject: Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back In-reply-to: References: <415517.1642543920@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Tue, 18 Jan 2022 21:23:08 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <438732.1642559356.1@sss.pgh.pa.us> Date: Tue, 18 Jan 2022 21:29:16 -0500 Message-ID: <438733.1642559356@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > Here's a patch, based in part on some off-list discussion with Andres. > I believe Andres has already confirmed that this fix works, but it > wouldn't hurt if Tom wants to verify it also. WFM too --- at least, pg_basebackup's "make check" passes now. regards, tom lane