Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFPVh-0054MA-38 for pgsql-committers@arkaria.postgresql.org; Wed, 22 Apr 2026 04:48:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wFPVg-00BmLo-2i for pgsql-committers@arkaria.postgresql.org; Wed, 22 Apr 2026 04:48:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFPVg-00BmLM-1C for pgsql-committers@lists.postgresql.org; Wed, 22 Apr 2026 04:48:24 +0000 Received: from mail-dy1-x1335.google.com ([2607:f8b0:4864:20::1335]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wFPVd-00000002CH8-2etD for pgsql-committers@lists.postgresql.org; Wed, 22 Apr 2026 04:48:23 +0000 Received: by mail-dy1-x1335.google.com with SMTP id 5a478bee46e88-2c15849aa2cso6747649eec.0 for ; Tue, 21 Apr 2026 21:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20251104.gappssmtp.com; s=20251104; t=1776833301; x=1777438101; darn=lists.postgresql.org; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=j17AV7JbazDMft85GulHkFNYzSJ4lVE2VprqgHNAUi4=; b=f1sRmlY4JSY71htm+He4qGjD+oWTJ2F72QnRng5HkBFL20dv5dyblwO3RhEpDQ9I/E O6LSzLxPp4ZdGXQC7ReYmiCwSTWJOafjqlHYj0RiogYCm7i8Xn591dltd5L6rSgjwMVs j7fRLWVgotNZwH/15MWNbC28MF44Rv5YD3fOplEZgUWh/rBvXrOk++dNhF49dZhic0qz VooTHMW/XTu6LZKpNz+3VZWobB6wosawIjHJY17Ecf/ku1F/aIbxmi918VgiDTEHiFCP 6lAfoCzyGcH2eW8HJ55waB5NcDeAaADFTYT3txDL/XHaNcnic/NdaTtSA06n+InTLr0M GkvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776833301; x=1777438101; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=j17AV7JbazDMft85GulHkFNYzSJ4lVE2VprqgHNAUi4=; b=pc1+dTRvkn8+C8k6i9c6y3n/nsRu5OHEbClzbJuvMTMZdFIkvC+ZB7PNRGwoJiepCr 9QXYrTHWaPoprOfRhhF1tUL0j8mts21SsIPgDMs5NRBFTVgw+ojZixLUc/MtUajFyy+n OCzz8/cLvt7hWGza8OESXfbUOIH3Ey35lkOneSngWKTG3k4bC3H/S8VRewKtE0ql5uLP RVidiX9t7bqs/HHyV4VrZnnRuRTU3l7ls4KMzbx6frCtX0XO+Q/UocI8nUNZrSLPi2X+ MvMbQyz2/oZRGLvMrMoJHRdbu4fYxT9toTAlNUL2k+5MhkMsv/zkjSH7IG7faPi80wua pwWw== X-Forwarded-Encrypted: i=1; AFNElJ83OlhGPw4TYlsozMJm5QN+FO72gth5FiMWGxkXFnNrqZmzeBcyVfiP9j03uuLaQmUQIFCyUdbbwlK268GESATS@lists.postgresql.org X-Gm-Message-State: AOJu0YzRYta+3z8axXq8kIVZpj2loCxq10+ULPu6/1WK5C7T3BJTLAQz yLtmgtR8IWG+y2RwM6BSqBnm4YyNPTkCXYH0dUCwuWl4pPedw/wqFhBudiBOnY6ONw== X-Gm-Gg: AeBDiesg7z1TUHeS6MoYzJ27oOVh3BQ/gwOX47MCmTpIvnQzuFOkllne5M3QI9OF8gF epCqTwuxV1yxR2j9I2r+yxUpfAkR/3pu7FxPCSdeebcRQJwVtRzI93QBhmVn00WAMTpmnHUs9Kn FD/KFyzVtpn9A1dKMA1j6DZ4CYc6S1nE6jF3h1yOZ78KX12SgEsBbdecL0+E+uH9+/2dGfHIB8g HNucb09a4Z7eJJ9SfcG2Kq1dmWdigpHGyJFVKx57+s1rm05l+7W0cjFOSDEzSjecMXIe5+9jI9M wYARXrSc7aB33X/kJQfauSLDmYH58YOi9MhMo6P+8RmXj3LQkQ7qXm2h6bgjAP/cXrMQjxJgob8 83rFqNmkPsAdaVsa2VFgW59dlCwWW0JovuWRJe9A6447I3/zSeOK5Um8P88e261kII1d+dFv2BA jC/Xe0vy9sHwy//bsVFauadOODM6ap/2R72U7WWWn7IbXniG3bR9dPmaq8RPJRnw== X-Received: by 2002:a05:7300:2a9c:b0:2e6:fe90:27ad with SMTP id 5a478bee46e88-2e6fe90454amr4664477eec.7.1776833300850; Tue, 21 Apr 2026 21:48:20 -0700 (PDT) Received: from jeff-laptop.lan (c-24-7-19-3.hsd1.ca.comcast.net. [24.7.19.3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e79c2954f6sm20401022eec.30.2026.04.21.21.48.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 21:48:20 -0700 (PDT) Message-ID: <4524ed61a015d3496fc008644dcb999bb31916a7.camel@j-davis.com> Subject: Re: pgsql: Perform provider-specific initialization in new functions. From: Jeff Davis To: Andrey Borodin Cc: Jeff Davis , pgsql-committers@lists.postgresql.org Date: Tue, 21 Apr 2026 21:48:17 -0700 In-Reply-To: <2153399092d446bc1137eee5f70ad7af70e9039e.camel@j-davis.com> References: <2FCB31FC-43E9-45F6-9AF4-4E199132B4E5@yandex-team.ru> <9e74ecd519ac5a1a2a5fefec86d261037f3db311.camel@j-davis.com> <2153399092d446bc1137eee5f70ad7af70e9039e.camel@j-davis.com> Content-Type: multipart/mixed; boundary="=-8RLvsinlmXu7m7o27vQt" User-Agent: Evolution 3.52.3-0ubuntu1.1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-8RLvsinlmXu7m7o27vQt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-04-16 at 11:42 -0700, Jeff Davis wrote: > I plan to commit this soon. >=20 > I don't plan to backport unless someone sees a reason that it should > be > backported (and if so, how far?). Actually, this does need to be backported, a NULL pointer dereference is easily reproducible on master and v18: PGOPTIONS=3D"-c zero_damaged_pages=3Don" \ pg_receivewal -D archive -U repl On 17 the symptom is slightly different but the fix is the same. I attached a new patch, and only the commit message is different, which I plan to backport to 17. There's another bug, though. Even with the patch applied, if you do the same pg_receivewal command immediately after starting the server (without any other connections), you get: FATAL: cannot read pg_class without having selected a database The path is similar: it's trying to do pg_parameter_aclcheck, but is unable to open pg_parameter_acl at all because it can't read pg_class. It seems to work if you connect another backend first, where it does some initialization first, through I haven't worked out the details. I think it goes back to when parameter ACLs were introduced in a0ffa885e47, so CC Mark Dilger. Regards, Jeff Davis --=-8RLvsinlmXu7m7o27vQt Content-Disposition: attachment; filename="v2-0001-catcache.c-always-use-C_COLLATION_OID.patch" Content-Type: text/x-patch; name="v2-0001-catcache.c-always-use-C_COLLATION_OID.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAzOWYwYmM4NjZiMDkyYTVkZWYzMTE4NGJmN2Y4Y2U3YjdmY2Q3Zjg5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBN b24sIDEzIEFwciAyMDI2IDEyOjA5OjQwIC0wNzAwClN1YmplY3Q6IFtQQVRDSCB2Ml0gY2F0Y2Fj aGUuYzogYWx3YXlzIHVzZSBDX0NPTExBVElPTl9PSUQuCgpUaGUgcHJvYmxlbSByZXBvcnQgd2Fz IGFib3V0IHNldHRpbmcgR1VDcyBpbiB0aGUgc3RhcnR1cCBwYWNrZXQgd2hlbgppbml0aWF0aW5n IGEgcmVwbGljYXRpb24gY29ubmVjdGlvbi4gU2V0dGluZyB0aGUgR1VDIHJlcXVpcmVkIGFuIEFD TApjaGVjaywgd2hpY2ggcGVyZm9ybWVkIGEgY2F0YWxvZyBsb29rdXAgb24gcGdfcGFyYW1ldGVy X2FjbC5wYXJuYW1lCih0eXBlIFRFWFQpLiBUaGUgY2F0YWxvZyBjYWNoZSB3YXMgaGFyZHdpcmVk IHRvIHVzZQpERUZBVUxUX0NPTExBVElPTl9PSUQgZm9yIHRleHQgYXR0cmlidXRlcywgYnV0IHdh bHNlbmRlciBuZXZlciBjYWxscwpDaGVja015RGF0YWJhc2UoKSwgc28gdGhlIGRlZmF1bHQgY29s bGF0aW9uIHdhcyB1bmluaXRpYWxpemVkIGFuZCBpdApjYXVzZWQgYSBOVUxMIHBvaW50ZXIgZGVy ZWZlcmVuY2UuCgpBcyB0aGUgY29tbWVudHMgc3RhdGVkLCB1c2luZyBERUZBVUxUX0NPTExBVElP Tl9PSUQgd2FzIGFyYml0cmFyeQphbnl3YXk6IGlmIHRoZSBjb2xsYXRpb24gYWN0dWFsbHkgbWF0 dGVyZWQsIGl0IHNob3VsZCB1c2UgdGhlIGNvbHVtbidzCmFjdHVhbCBjb2xsYXRpb24uIChJbiB0 aGUgY2F0YWxvZywgc29tZSB0ZXh0IGNvbHVtbnMgYXJlIHRoZSBkZWZhdWx0CmNvbGxhdGlvbiBh bmQgc29tZSBhcmUgIkMiLikKCkZpeCBieSB1c2luZyBDX0NPTExBVElPTl9PSUQsIHdoaWNoIGRv ZXNuJ3QgcmVxdWlyZSBhbnkgaW5pdGlhbGl6YXRpb24KYW5kIGlzIGFsd2F5cyBhdmFpbGFibGUu IFdoZW4gYW55IGRldGVybWluaXN0aWMgY29sbGF0aW9uIHdpbGwgZG8sCml0J3MgYmVzdCB0byBj b25zaXN0ZW50bHkgdXNlIHRoZSBzaW1wbGVzdCBhbmQgZmFzdGVzdCBvbmUsIHNvIHRoaXMgaXMK YSBnb29kIGlkZWEgYW55d2F5LgoKVGhlcmUgbWF5IGJlIG90aGVyIHByb2JsZW1zIGluIHRoaXMg Z2VuZXJhbCBhcmVhLCBzbyB0aGlzIHNob3VsZCBub3QKYmUgY29uc2lkZXJlZCBhIGNvbXBsZXRl IGZpeC4gQnV0IHRoaXMgaXMgYW4gaW5kZXBlbmRlbnRseSBnb29kIGNoYW5nZQphbmQgc29sdmVz IHRoZSBpbW1lZGlhdGUgcHJvYmxlbS4KClJlcG9ydGVkLWJ5OiBBbmRyZXkgQm9yb2RpbiA8eDRt bW1AeWFuZGV4LXRlYW0ucnU+CkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVzL20vRDE4QUQ3 MkEtNTAwNC00RUY4LUFGODAtMTA3MzJBRjY3N0ZBQHlhbmRleC10ZWFtLnJ1CkJhY2twYXRjaC10 aHJvdWdoOiAxNwotLS0KIHNyYy9iYWNrZW5kL3V0aWxzL2NhY2hlL2NhdGNhY2hlLmMgfCAyMSAr KysrKysrKysrKysrKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCA1 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2NhY2hlL2NhdGNh Y2hlLmMgYi9zcmMvYmFja2VuZC91dGlscy9jYWNoZS9jYXRjYWNoZS5jCmluZGV4IDg3ZWQ1NTA2 NDYwLi5hOGU3YmY2NDlkMiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvdXRpbHMvY2FjaGUvY2F0 Y2FjaGUuYworKysgYi9zcmMvYmFja2VuZC91dGlscy9jYWNoZS9jYXRjYWNoZS5jCkBAIC0yMDUs NiArMjA1LDEwIEBAIG5hbWVlcWZhc3QoRGF0dW0gYSwgRGF0dW0gYikKIAljaGFyCSAgICpjYSA9 IE5hbWVTdHIoKkRhdHVtR2V0TmFtZShhKSk7CiAJY2hhcgkgICAqY2IgPSBOYW1lU3RyKCpEYXR1 bUdldE5hbWUoYikpOwogCisJLyoKKwkgKiBDYXRhbG9ncyBvbmx5IHVzZSBkZXRlcm1pbmlzdGlj IGNvbGxhdGlvbnMsIHNvIGlnbm9yZSBjb2x1bW4gY29sbGF0aW9uCisJICogYW5kIHVzZSBmYXN0 IHBhdGguCisJICovCiAJcmV0dXJuIHN0cm5jbXAoY2EsIGNiLCBOQU1FREFUQUxFTikgPT0gMDsK IH0KIApAQCAtMjEzLDYgKzIxNywxMCBAQCBuYW1laGFzaGZhc3QoRGF0dW0gZGF0dW0pCiB7CiAJ Y2hhcgkgICAqa2V5ID0gTmFtZVN0cigqRGF0dW1HZXROYW1lKGRhdHVtKSk7CiAKKwkvKgorCSAq IENhdGFsb2dzIG9ubHkgdXNlIGRldGVybWluaXN0aWMgY29sbGF0aW9ucywgc28gaWdub3JlIGNv bHVtbiBjb2xsYXRpb24KKwkgKiBhbmQgdXNlIGZhc3QgcGF0aC4KKwkgKi8KIAlyZXR1cm4gaGFz aF9ieXRlcygodW5zaWduZWQgY2hhciAqKSBrZXksIHN0cmxlbihrZXkpKTsKIH0KIApAQCAtMjQ0 LDE3ICsyNTIsMjAgQEAgc3RhdGljIGJvb2wKIHRleHRlcWZhc3QoRGF0dW0gYSwgRGF0dW0gYikK IHsKIAkvKgotCSAqIFRoZSB1c2Ugb2YgREVGQVVMVF9DT0xMQVRJT05fT0lEIGlzIGZhaXJseSBh cmJpdHJhcnkgaGVyZS4gIFdlIGp1c3QKLQkgKiB3YW50IHRvIHRha2UgdGhlIGZhc3QgImRldGVy bWluaXN0aWMiIHBhdGggaW4gdGV4dGVxKCkuCisJICogQ2F0YWxvZ3Mgb25seSB1c2UgZGV0ZXJt aW5pc3RpYyBjb2xsYXRpb25zLCBzbyBpZ25vcmUgY29sdW1uIGNvbGxhdGlvbgorCSAqIGFuZCB1 c2UgIkMiIGxvY2FsZSBmb3IgZWZmaWNpZW5jeS4KIAkgKi8KLQlyZXR1cm4gRGF0dW1HZXRCb29s KERpcmVjdEZ1bmN0aW9uQ2FsbDJDb2xsKHRleHRlcSwgREVGQVVMVF9DT0xMQVRJT05fT0lELCBh LCBiKSk7CisJcmV0dXJuIERhdHVtR2V0Qm9vbChEaXJlY3RGdW5jdGlvbkNhbGwyQ29sbCh0ZXh0 ZXEsIENfQ09MTEFUSU9OX09JRCwgYSwgYikpOwogfQogCiBzdGF0aWMgdWludDMyCiB0ZXh0aGFz aGZhc3QoRGF0dW0gZGF0dW0pCiB7Ci0JLyogYW5hbG9nb3VzbHkgaGVyZSBhcyBpbiB0ZXh0ZXFm YXN0KCkgKi8KLQlyZXR1cm4gRGF0dW1HZXRJbnQzMihEaXJlY3RGdW5jdGlvbkNhbGwxQ29sbCho YXNodGV4dCwgREVGQVVMVF9DT0xMQVRJT05fT0lELCBkYXR1bSkpOworCS8qCisJICogQ2F0YWxv Z3Mgb25seSB1c2UgZGV0ZXJtaW5pc3RpYyBjb2xsYXRpb25zLCBzbyBpZ25vcmUgY29sdW1uIGNv bGxhdGlvbgorCSAqIGFuZCB1c2UgIkMiIGxvY2FsZSBmb3IgZWZmaWNpZW5jeS4KKwkgKi8KKwly ZXR1cm4gRGF0dW1HZXRJbnQzMihEaXJlY3RGdW5jdGlvbkNhbGwxQ29sbChoYXNodGV4dCwgQ19D T0xMQVRJT05fT0lELCBkYXR1bSkpOwogfQogCiBzdGF0aWMgYm9vbAotLSAKMi40My4wCgo= --=-8RLvsinlmXu7m7o27vQt--