Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcSyP-00081g-Ut for pgsql-committers@arkaria.postgresql.org; Mon, 18 Oct 2021 13:46:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mcSyO-0003Yv-Rg for pgsql-committers@arkaria.postgresql.org; Mon, 18 Oct 2021 13:46:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcSyO-0003Ym-I1 for pgsql-committers@lists.postgresql.org; Mon, 18 Oct 2021 13:46:40 +0000 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcSyM-0007e4-D2 for pgsql-committers@lists.postgresql.org; Mon, 18 Oct 2021 13:46:40 +0000 Received: from [192.168.1.113] (dsl-hkibng22-54faa4-119.dhcp.inet.fi [84.250.164.119]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 00A8F1B0004B for ; Mon, 18 Oct 2021 16:46:35 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1634564796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G6GpqZVO+7EGDv+iz2uYrHifpzaAdWSnhYtfjtCcnW0=; b=TuWLojlUKCAmdTaKiPtbFiLzMVpRgG/vx9IpaeYj1yLQMADSoMTCELqnunL5Y0zQyG390V LMS0FRqGpFm+PBku41+ExJZxQQHKgMsFci14M3rE2329gLpz1sS20B2XCB7ZBLxjWsMIP1 bjJjGXTJB5NpJJ2aqmtHZPU8cC1XtM3yjyamhVmcHXoX/DNP5OOQCRIiholDkYkTo+VFM6 D3LX9/MUbJl6zZ5+BiuynKrkeQFDkpsr64fRA90ZzT5QHrC71pcT/V/RexT9ehUW/7i8+L p3LhNJyRjg2a1ihb7eNFaBuo4kLpRGDPSijq4sEm69Zagd0wKOXqjNTMKhQQ4Q== Subject: Re: pgsql: Replace polyphase merge algorithm with a simple balanced k-way m To: pgsql-committers@lists.postgresql.org References: From: Heikki Linnakangas Message-ID: <45e2ee8f-205e-6150-938e-3eecd0ed2fef@iki.fi> Date: Mon, 18 Oct 2021 16:46:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1634564796; a=rsa-sha256; cv=none; b=c6BBGAqIbiG64E38vye+h3ZdVKCq0v5dlUElEDg2mM3Xjq7opoZpnnT0E4nKMOF1+VTP6A 0qKvPuMpXyDDrg6Mbn3LuEB1zn3qoCOzlH32/eDsXe3ApVr4wFucjDdNMv7SsGtaUUqk8V lPED6pQjlWEmLIuLEZl/7CdOUhgzKmF9uwhHi25FFJy58MoVGdd+3CI4DGy1cKQDh6sVSJ 6aBnnhIboZQU+PB4lZHtKxdr1qqsQ5M6jDjLbKY4Tvg+3xW62/Jwi21rZ6iEzSXjCScOeH SOZJlrJGFdfuR3XZCauLFtWwPIX1g7q3ElPOrPZMZfpNRlOap0SZtQ6Xtctobw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1634564796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G6GpqZVO+7EGDv+iz2uYrHifpzaAdWSnhYtfjtCcnW0=; b=j9EQ75XnIC+zM/NSF2E0AJkveSnImlX4w0pELaMLNz5Zv8dXpvXUQASErJBJ64sQDhbZLa uM/VDI42boGmPYWgQdPStEGn8e4hdW+fW7AJ8FxWtJMyf6oDGnzRrv/YOdIabOF0BLRVfl CFWMCUB0+M3jyEfrXnsP4hdPgfT96ktzpwxQh3inmYtRwXMn3rbFUpK8h4F1ErXqvi0kyz 088eZT1zdzkxDLokp75cyn/nBLcCh78vj1+k4U3+fbrhHFaHfwGK9D9p536vuLo3BIPDh9 ZtGmnCkIkpIcP3Lh9zcK1WVn36kJd2ajXhDtzOyTJrfSUswSWqZ6xD1Dn+l6ow== List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 18/10/2021 15:15, Heikki Linnakangas wrote: > Replace polyphase merge algorithm with a simple balanced k-way merge. This patch made some buildfarm animals fail in the isolation tests. 'eelpout' seems to have ran out of disk space: > +setup failed: ERROR: could not write to file "base/pgsql_tmp/pgsql_tmp915834.0.fileset/0.1": No space left on device Maybe I was unlucky. However, 'francolin', 'desmoxytes', 'dragonet' and 'idiacanthus' also failed, in the same test: > ==~_~===-=-===~_~== pgsql.build/src/test/isolation/output_iso/regression.diffs ==~_~===-=-===~_~== > diff -U3 /mnt/resource/bf/build/francolin/HEAD/pgsql.build/../pgsql/src/test/isolation/expected/multiple-row-versions.out /mnt/resource/bf/build/francolin/HEAD/pgsql.build/src/test/isolation/output_iso/results/multiple-row-versions.out > --- /mnt/resource/bf/build/francolin/HEAD/pgsql.build/../pgsql/src/test/isolation/expected/multiple-row-versions.out 2021-10-05 04:13:04.811944633 +0000 > +++ /mnt/resource/bf/build/francolin/HEAD/pgsql.build/src/test/isolation/output_iso/results/multiple-row-versions.out 2021-10-18 12:34:35.036779419 +0000 > @@ -2,10 +2,9 @@ > > starting permutation: rx1 wx2 c2 wx3 ry3 wy4 rz4 c4 c3 wz1 c1 > step rx1: SELECT * FROM t WHERE id = 1000000; > - id|txt > --------+--- > -1000000| > -(1 row) > +id|txt > +--+--- > +(0 rows) > > step wx2: UPDATE t SET txt = 'b' WHERE id = 1000000; > step c2: COMMIT; > @@ -26,5 +25,4 @@ > step c4: COMMIT; > step c3: COMMIT; > step wz1: UPDATE t SET txt = 'a' WHERE id = 1; > -ERROR: could not serialize access due to read/write dependencies among transactions > step c1: COMMIT; > ==~_~===-=-===~_~== inst/logfile ==~_~===-=-===~_~== The symptom is different, there is no "out of disk space" error, but it kind of looks like an index was built incorrectly, because the simple SELECT doesn't return the row that it should. That sure smells like a bug in the new sorting code. I haven't been able to reproduce that yet, but I'll keep trying. It's strange that this doesn't happen in any other test, that is a very ordinary table with a very ordinary index. - Heikki