Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZiXT-0007Bd-QW for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 00:19:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZiXR-0005pR-P6 for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 00:19:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZiXR-0005pI-IF for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 00:19:45 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZiXP-00071M-3T for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 00:19:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22V0JfH2474105; Wed, 30 Mar 2022 20:19:41 -0400 From: Tom Lane To: Andrew Dunstan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches In-reply-to: References: Comments: In-reply-to Andrew Dunstan message dated "Wed, 30 Mar 2022 15:25:41 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <474103.1648685981.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 30 Mar 2022 20:19:41 -0400 Message-ID: <474104.1648685981@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > Make PostgreSQL::Test::Cluster compatible with all live branches prairiedog is unhappy [1], seemingly as a result of this patch: t/001_repl_stats....Can't locate parent.pm in @INC (@INC contains: ../../s= rc/test/perl/ . /usr/local/perl5.8.3/lib/5.8.3/darwin-2level /usr/local/pe= rl5.8.3/lib/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3 /usr/local/= perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_= perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3 /usr/loc= al/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/si= te_perl/5.8.3 /usr/local/perl5.8.3/lib/site_perl . /usr/local/perl5.8.3/li= b/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3 /usr/local/perl5.8.3/= lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3= /usr/local/perl5.8.3/lib/site_perl .) at ../../src/test/perl//PostgreSQL/= Test/Cluster.pm line 2921. BEGIN failed--compilation aborted at ../../src/test/perl//PostgreSQL/Test/= Cluster.pm line 2921. I think this means that its old Perl version misinterprets use parent -norequire, qw(PostgreSQL::Test::Cluster); as a request to include "parent.pm". Is there a more backwards-compatible way to spell that? regards, tom lane [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dprairiedog&d= t=3D2022-03-30%2021%3A23%3A58