Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uo9Qd-00H2Od-2d for pgsql-committers@arkaria.postgresql.org; Mon, 18 Aug 2025 23:38:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uo9Qb-003UIX-Lp for pgsql-committers@arkaria.postgresql.org; Mon, 18 Aug 2025 23:38:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uo9Qb-003UIO-Ev for pgsql-committers@lists.postgresql.org; Mon, 18 Aug 2025 23:38:14 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uo9QZ-000bIy-2U for pgsql-committers@lists.postgresql.org; Mon, 18 Aug 2025 23:38:13 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 57INc9os476684; Mon, 18 Aug 2025 19:38:09 -0400 From: Tom Lane To: Michael Paquier cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file In-reply-to: References: <345438.1755524834@sss.pgh.pa.us> Comments: In-reply-to Michael Paquier message dated "Tue, 19 Aug 2025 08:24:04 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <476682.1755560289.1@sss.pgh.pa.us> Date: Mon, 18 Aug 2025 19:38:09 -0400 Message-ID: <476683.1755560289@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote: >> Couldn't this have removed some #include-s from multixact.c? > Right. funcapi.h and fmgrprotos.h are direct dependencies, but > looking closer it is also possible to remove four more of them. Sounds good! regards, tom lane