Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZjMT-0001cN-17 for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 01:12:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZjMR-0001CZ-NH for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 01:12:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZjMR-0001CP-FG for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 01:12:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZjMM-0005m0-Fg for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 01:12:26 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22V1CK6F479468; Wed, 30 Mar 2022 21:12:20 -0400 From: Tom Lane To: Andrew Dunstan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches In-reply-to: <393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net> References: <474104.1648685981@sss.pgh.pa.us> <393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net> Comments: In-reply-to Andrew Dunstan message dated "Wed, 30 Mar 2022 21:01:07 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <479466.1648689140.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 30 Mar 2022 21:12:20 -0400 Message-ID: <479467.1648689140@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: >> On Mar 30, 2022, at 8:19 PM, Tom Lane wrote: >> I think this means that its old Perl version misinterprets >> use parent -norequire, qw(PostgreSQL::Test::Cluster); >> as a request to include "parent.pm". Is there a more >> backwards-compatible way to spell that? > Not that I know of. Googling tells me it was a core module from 5.10.1. = I can revert tomorrow if necessary :-( Hmm. I checked not too long ago, and these are the buildfarm animals that would be broken: prairiedog | 2022-03-23 05:04:02 | configure: using perl 5.8.3 anole | 2022-03-24 10:40:08 | configure: using perl 5.8.8 gharial | 2022-03-24 18:32:22 | configure: using perl 5.8.8 locust | 2022-03-19 22:17:53 | configure: using perl 5.8.8 gaur | 2022-03-19 15:00:54 | configure: using perl 5.8.9 I could update prairiedog and gaur (... probably), but hard to say about the others. It seems kind of sad for a backwards-compatibility patch to force a major move of our minimum Perl version. OTOH, if there's no other good way to do it, maybe we gotta. Another possibility is that maybe parent.pm could be successfully installed into a 5.8.x installation. I can't speak for those other animals, but mine at least are already frankencritters. regards, tom lane