Subject: Re: pgsql: Add support for temporary replication slots
To: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>
References: <27274.1481557380@sss.pgh.pa.us> <27833.1481558144@sss.pgh.pa.us>
 <62935e6f-4f1b-c433-e0fa-7f936a38b3e5@2ndquadrant.com>
 <22907.1481571177@sss.pgh.pa.us> <15713.1481585953@sss.pgh.pa.us>
 <314cae39-2e7d-f5a3-d226-cfb80cf80481@2ndquadrant.com>
 <18684.1481589637@sss.pgh.pa.us>
 <48b2c017-695d-b5ac-2ff4-89b939b3e8f9@2ndquadrant.com>
 <20161213004903.iito2pefdrrjgny5@alap3.anarazel.de>
 <6886c56a-f6c8-3c44-53a1-dae6c24afb76@2ndquadrant.com>
 <20161213010059.dn64rrb3u7zxnnwk@alap3.anarazel.de>
 <19997.1481591281@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>, pgsql-committers@postgresql.org
From: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Message-ID: <495584eb-c8c8-90ba-0e21-1b0ecc148bf4@2ndquadrant.com>
Date: Tue, 13 Dec 2016 02:21:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <19997.1481591281@sss.pgh.pa.us>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

On 13/12/16 02:08, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2016-12-13 01:57:01 +0100, Petr Jelinek wrote:
>>> I mentioned that as possible solution upthread, I am only worried that
>>> the failure scenario is basically infinite loop.
> 
>> I don't see the problem with that. If you're really concerned you can
>> set a statement timeout.
> 
> I don't think "change the test" is the right response here.
> I think the problem is that we're disconnecting from the slot at the
> wrong step of backend shutdown, and that we need to fix that before
> it bites us on some more painful parts of our anatomies.  You can't
> just throw darts at the code when deciding where to do things, and
> proc.c is NOT the place that should be concerned with replication
> slots.
> 

It has been concerned with replication slots since 9.4 so it's not like
it's newly invented concern. As Andres says, we don't have better place
to put it to at the moment.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers