Message-ID: <499821F3.7050004@hagander.net>
Date: Sun, 15 Feb 2009 15:08:51 +0100
From: Magnus Hagander <magnus@hagander.net>
User-Agent: Thunderbird 2.0.0.19 (X11/20090105)
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: pgsql-hackers@postgreSQL.org
Subject: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct
	encoding on Windows.
References: <20090122100948.89F977559ED@cvs.postgresql.org>
	<20643.1232666867@sss.pgh.pa.us>
In-Reply-To: <20643.1232666867@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Tom Lane wrote:
> mha@postgresql.org (Magnus Hagander) writes:
>> Explicitly bind gettext to the correct encoding on Windows.
> 
> I have a couple of objections to this patch.  First, what happens if
> it fails to find a matching table entry?  (The existing answer is
> "nothing", but that doesn't seem right.)  Second and more critical,
> it adds still another data structure that has to be maintained when
> the list of encodings changes, and it doesn't even live in the same
> file as any existing encoding-information table.
> 
> What makes more sense to me is to add a table to encnames.c that
> provides the gettext name of every encoding that we support.

Do you mean a separate table there, or should we add a new column to one
of the existing tables?

//Magnus