Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id DF520632F9B for ; Thu, 2 Apr 2009 05:50:22 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 32281-05 for ; Thu, 2 Apr 2009 05:50:10 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from svr2.hagander.net (svr2.hagander.net [88.198.128.226]) by mail.postgresql.org (Postfix) with ESMTP id 26255632A8C for ; Thu, 2 Apr 2009 05:50:11 -0300 (ADT) Received: from dynamic.hagander.net ([127.0.0.1]) (encrypted and authenticated) by svr2.hagander.net (Postfix) with ESMTP id 715C3DCC12B; Thu, 2 Apr 2009 10:50:09 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by mha-laptop.hagander.net (Postfix) with ESMTP id 1592C1240B2; Thu, 2 Apr 2009 10:50:09 +0200 (CEST) Message-ID: <49D47C40.5040300@hagander.net> Date: Thu, 02 Apr 2009 10:50:08 +0200 From: Magnus Hagander User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: Tom Lane CC: pgsql-hackers@postgreSQL.org Subject: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows. References: <20090122100948.89F977559ED@cvs.postgresql.org> <20643.1232666867@sss.pgh.pa.us> <499821F3.7050004@hagander.net> <22474.1234718514@sss.pgh.pa.us> In-Reply-To: <22474.1234718514@sss.pgh.pa.us> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200904/67 X-Sequence-Number: 136170 Tom Lane wrote: > Magnus Hagander writes: >> Tom Lane wrote: >>> What makes more sense to me is to add a table to encnames.c that >>> provides the gettext name of every encoding that we support. > >> Do you mean a separate table there, or should we add a new column to one >> of the existing tables? > > Whichever seems to make more sense is fine with me. I just don't want > add-an-encoding maintenance requirements spread across N different > source files. I was about to start looking at this when that other thread (http://archives.postgresql.org//pgsql-hackers/2009-03/msg01270.php) started about related issues on other platforms. Seems we should have a "coordinated fix" for this, so I'm going to want and see what come sout of that one. Unless I'm misunderstanding thigns and they're not related? //Magnus