Message-ID: <49DC7E11.2050501@enterprisedb.com>
Date: Wed, 08 Apr 2009 13:36:01 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: Magnus Hagander <magnus@hagander.net>
CC: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgreSQL.org
Subject: Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext to
	the correct encoding on Windows.
References: <20090122100948.89F977559ED@cvs.postgresql.org>
	<20643.1232666867@sss.pgh.pa.us> <499821F3.7050004@hagander.net>
	<22474.1234718514@sss.pgh.pa.us> <49D47C40.5040300@hagander.net>
In-Reply-To: <49D47C40.5040300@hagander.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Magnus Hagander wrote:
> Tom Lane wrote:
>> Magnus Hagander <magnus@hagander.net> writes:
>>> Tom Lane wrote:
>>>> What makes more sense to me is to add a table to encnames.c that
>>>> provides the gettext name of every encoding that we support.
>>> Do you mean a separate table there, or should we add a new column to one
>>> of the existing tables?
>> Whichever seems to make more sense is fine with me.  I just don't want
>> add-an-encoding maintenance requirements spread across N different
>> source files.
> 
> I was about to start looking at this when that other thread
> (http://archives.postgresql.org//pgsql-hackers/2009-03/msg01270.php)
> started about related issues on other platforms. Seems we should have a
> "coordinated fix" for this, so I'm going to want and see what come sout
> of that one. Unless I'm misunderstanding thigns and they're not related?

I've committed a fairly trivial patch per Peter's suggestion to fix the 
other thread's issue. I left the table as is, so whatever refactorings 
were planned can now be applied.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com