Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 101761337B67 for ; Mon, 7 Mar 2011 03:30:03 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 96046-10 for ; Mon, 7 Mar 2011 07:29:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from exprod7og107.obsmtp.com (exprod7og107.obsmtp.com [64.18.2.167]) by mail.postgresql.org (Postfix) with ESMTP id 6D5A11337999 for ; Mon, 7 Mar 2011 03:29:53 -0400 (AST) Received: from source ([209.85.215.171]) (using TLSv1) by exprod7ob107.postini.com ([64.18.6.12]) with SMTP ID DSNKTXSJcEB4u5ZSaJHa5TzFzWCmz+f/vCTc@postini.com; Sun, 06 Mar 2011 23:29:53 PST Received: by eydd26 with SMTP id d26so1399723eyd.16 for ; Sun, 06 Mar 2011 23:29:51 -0800 (PST) Received: by 10.14.52.15 with SMTP id d15mr2094808eec.18.1299482990993; Sun, 06 Mar 2011 23:29:50 -0800 (PST) Received: from [192.168.1.183] (dsl-hkibrasgw2-ff7ac300-240.dhcp.inet.fi [88.195.122.240]) by mx.google.com with ESMTPS id t50sm1751562eeh.6.2011.03.06.23.29.49 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 06 Mar 2011 23:29:50 -0800 (PST) Message-ID: <4D74896C.5030402@enterprisedb.com> Date: Mon, 07 Mar 2011 09:29:48 +0200 From: Heikki Linnakangas User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI; rv:1.9.1.16) Gecko/20101226 Icedove/3.0.11 MIME-Version: 1.0 To: Simon Riggs CC: Andrew Dunstan , pgsql-hackers@postgresql.org Subject: Re: Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication. References: <4D741441.2090704@dunslane.net> <1299454125.1696.6138.camel@ebony> In-Reply-To: <1299454125.1696.6138.camel@ebony> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.119 tagged_above=-5 required=5 tests=BAYES_00=-1.9, FS_REPLICA=3.599, RCVD_IN_DNSWL_MED=-2.3, SARE_SPEC_REPLICA=0.72 X-Spam-Level: X-Archive-Number: 201103/437 X-Sequence-Number: 183687 On 07.03.2011 01:28, Simon Riggs wrote: > On Sun, 2011-03-06 at 18:09 -0500, Andrew Dunstan wrote: >> >> On 03/06/2011 05:51 PM, Simon Riggs wrote: >>> Efficient transaction-controlled synchronous replication. >> >> I'm glad this is in, but I thought we agreed NOT to call it "synchronous >> replication". > > The discussion on the thread was that its not sync rep unless we have > the strictest guarantees. We have the strictest guarantees, so it > qualifies as sync rep. What do you mean by "strictes guarantees"? I don't see allow_synchronous_standby setting in the committed patch. I presume you didn't make allow_synchronous_standby=off the default behavior. Also, the documentation that describes this as two-safe replication and claims that "the only possibility that data can be lost is if both the primary and the standby suffer crashes at the same time" needs big fat caveats to clarify that this doesn't actually achieve those guarantees. Please change the name. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com