Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <519380.1764362419@sss.pgh.pa.us>
Date: Sat, 29 Nov 2025 09:54:25 +0800
Cc: =?utf-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
 Jeff Davis <jdavis@postgresql.org>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4F65CCF2-9184-4D37-990E-C311E3425293@gmail.com>
References: <202511281759.7zxt6cjzikzx@alvherre.pgsql>
 <519380.1764362419@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/4F65CCF2-9184-4D37-990E-C311E3425293%40gmail.com>
Precedence: bulk


> On Nov 29, 2025, at 04:40, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> =3D?utf-8?Q?=3DC3=3D81lvaro?=3D Herrera <alvherre@kurilemu.de> writes:
>> On 2025-Nov-26, Jeff Davis wrote:
>>> Inline pg_ascii_tolower() and pg_ascii_toupper().
>=20
>> I think this broke the CI on (some flavors of?) Windows.  In
>> https://cirrus-ci.com/task/6080935063453696
>> I got
>=20
>> [19:09:39.518] =
C:/msys64/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/15.2.0/../../../../x86_=
64-w64-mingw32/bin/ld.exe: =
src/backend/postgres_lib.a.p/commands_event_trigger.c.obj: in function =
`filter_list_to_array':
>> [19:09:39.518] =
c:\cirrus\build/../src/backend/commands/event_trigger.c:377:(.text+0x2a5):=
 undefined reference to `pg_ascii_toupper'
>=20
> That's bizarre.  I checked recent cfbot rebuilds of some of my patches
> and there's no problem, also just looking at port.h it's impossible
> to see how this could happen.  Some weird compiled-code caching
> misbehavior in CI, perhaps?
>=20
> regards, tom lane
>=20
>=20

ec4997a moved the two functions from pgstrcasecmp.c to port.h and made =
them inline, so maybe some old .o were not rebuilt and still need to =
link to the old functions.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/