Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tzvOQ-008fAA-Gd for pgsql-committers@arkaria.postgresql.org; Wed, 02 Apr 2025 10:32:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tzvOP-00CEUu-3b for pgsql-committers@arkaria.postgresql.org; Wed, 02 Apr 2025 10:32:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tzvOO-00CEUd-Sg for pgsql-committers@lists.postgresql.org; Wed, 02 Apr 2025 10:32:20 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tzvOM-002wk2-1n for pgsql-committers@lists.postgresql.org; Wed, 02 Apr 2025 10:32:20 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 8909544386; Wed, 2 Apr 2025 10:32:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vondra.me; s=gm1; t=1743589937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vN6Fjp8ESpBne8ahv39KGgc5bWgKjNMuu0HaTPWIFiI=; b=ox/px+DQp2/h1R6vTyGRbtVEPteCx71UYRlW+2cfM0tVnqfE/bjdD9u5teKB5HhrhcWrOL mXRXPc6fLfbL1kn7RPI/4Lsaut2mXZgk2vH7R/IGIG8S9CatGh0Szx2dXbci9emsduJSnG wLE1zxVsv7T8TOenIBvBp5DvlEnHrD+tqKnDLtoDXB228v/MEylz0u7W+FFvzTn6w6n5LL 5XKr5dNMeX6kac18+aMhOIkqVR8H543XYkmFSiyW1SD5+vccv+Qt8eohnqP2g6M5YH3MN9 J4YZPi9OsE+me08vJiofj//vC50ktVhzkk7hVdMTItr/zLAKOFNrpM+F5RGrmQ== Message-ID: <4b7f56b0-61af-49b9-ad99-66b18776e24d@vondra.me> Date: Wed, 2 Apr 2025 12:32:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Allow parallel CREATE INDEX for GIN indexes To: Peter Eisentraut , Tomas Vondra , pgsql-committers@lists.postgresql.org References: <35b1a8bd-5501-407f-b100-22f91834fcc8@eisentraut.org> <83b0c9ce-06ad-4aec-915f-d97ccc0362e3@eisentraut.org> Content-Language: en-US From: Tomas Vondra In-Reply-To: <83b0c9ce-06ad-4aec-915f-d97ccc0362e3@eisentraut.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddukeehgeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpefvohhmrghsucggohhnughrrgcuoehtohhmrghssehvohhnughrrgdrmhgvqeenucggtffrrghtthgvrhhnpeekffdvudegteefieelffetkeelffeggffhuefffefhleekleethfefieeggfffkeenucfkphepkeeirdegledrvddvledrudelfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeekiedrgeelrddvvdelrdduleefpdhhvghloheplgdutddrudefjedrtddrvdgnpdhmrghilhhfrhhomhepthhomhgrshesvhhonhgurhgrrdhmvgdpnhgspghrtghpthhtohepfedprhgtphhtthhopehpvghtvghrsegvihhsvghnthhrrghuthdrohhrghdprhgtphhtthhopehtohhmrghsrdhvohhnughrrgesphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtohepphhgshhqlhdqtghomhhmihhtthgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-GND-Sasl: tomas@vondra.me List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 4/1/25 15:30, Peter Eisentraut wrote: > On 07.03.25 22:22, Peter Eisentraut wrote: >> The new tuplesort_getgintuple() in tuplesortvariants.c has a branch >> that does "return false" even though the function's return type is >> GinTuple *.  That is probably a mistake.  Check please. >> >> Also, this code contains a "pgrminclude ignore", but we don't use >> those anymore. > > Fixed committed. > Thank you! I apparently missed your report on pgsql-committers :-( regards -- Tomas Vondra