Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rxafD-009uOW-7a for pgsql-committers@arkaria.postgresql.org; Thu, 18 Apr 2024 22:55:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rxafA-00BP95-U3 for pgsql-committers@arkaria.postgresql.org; Thu, 18 Apr 2024 22:55:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rxafA-00BP8s-Ij for pgsql-committers@lists.postgresql.org; Thu, 18 Apr 2024 22:55:28 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rxaf7-003WWi-LM for pgsql-committers@lists.postgresql.org; Thu, 18 Apr 2024 22:55:27 +0000 Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-4375b8b4997so8879581cf.2 for ; Thu, 18 Apr 2024 15:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1713480924; x=1714085724; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PIcydaVu1bV+iySljDg/bbHNiUMrvNGfO4RCa2vHXCk=; b=vpB/9TSHaOI+mokHW3ZSE0/G4xVcyCrGQiq+cWSPuEt70vfRN5u4N+QoarMWIFjfxI pSfxb7VaQjPJN8F1EIctnMJsdf06L5QcsRDtE0klScUHqZDy1aA02Of2PvhdFsOGAVah 2BmQOj9Zj+gHvPbW5wwfOGw/SEJz6Y1W7NRaoaAaJ3K2YQ2qt5deM4+O9MzA+0lo9bQT 0UD6sDIXbX9MfYPDhhG9O7pWS+++TlWrxpavy4Dhn03kg68wyr9CC4VIws/7kFwMuwZi lM9opmiJpSxu3lpvIVJoLngSVUVh/4NCVN3FUbJmYo9umyB454egzt1BA48FYp5u4zKt 2rmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713480924; x=1714085724; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PIcydaVu1bV+iySljDg/bbHNiUMrvNGfO4RCa2vHXCk=; b=aS1IWzsdEdTzQxp+XGhsxNx3ENXKvcSGeTR9eg/mV28b9qYqtR9LqMxsC6R2fVaxA1 65Y1HmWWjv4n+dNH1kgOZsIaihtWhwkg5Jffg5v9WvA7vVojyO7GMCnY1bNcQ7oR6EcI ENwWYo6klQDstr1+bWYVzmDSrjlLpNzpvzWq8krTtv0f6DkO+ReUbXlcoN0ywJMujQ9b J6OvoFosLoy3bkoSIaQsyK7J2decC+JiROWZHZrpi9qU/zDOciFGoY6na4jRNS4DRo0g HHhKJTtZB2r+hg0bNeDBraKfcgSfAAHVWcUwnpmGRZY9RFxm9uI5rYVaXxCW8yemPCbp 0KxA== X-Forwarded-Encrypted: i=1; AJvYcCXlbSwnL38uiCKxPPqJhnCjispyWWcmafFmnmjYxQnK8vYzeDReDPt9MPX5LcmY8H9O5ioDmo2vLRGSsisul5ZaRMSYOuFXcyd9EfLT0ESC9pRrF0UD X-Gm-Message-State: AOJu0Yygwxm6sZDU0xuAQP5ZEkWCeLqoHGgrdCKSGRG6w1qFEGAFaulE gEhFLmUhhma4zl1Hh2OB3MwAPf55m6RAZJurKOISl/g5M4Kd7m5hQ9FW5TkqiSQ= X-Google-Smtp-Source: AGHT+IHWTDtW1O1ZIb7bsdijMd9SerTT7cccYPDTep1lmrUw0xFidKqCJvnHQQvpUpFgh/PacPZoJQ== X-Received: by 2002:ac8:7e92:0:b0:437:bec5:6dfc with SMTP id w18-20020ac87e92000000b00437bec56dfcmr502556qtj.38.1713480923687; Thu, 18 Apr 2024 15:55:23 -0700 (PDT) Received: from ?IPV6:2605:a601:9180:9800::2bb? ([2605:a601:9180:9800::2bb]) by smtp.googlemail.com with ESMTPSA id b5-20020ac86bc5000000b004343d542598sm1067063qtt.62.2024.04.18.15.55.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Apr 2024 15:55:23 -0700 (PDT) Message-ID: <4cc4dc47-ca2b-4129-8784-db69b5f82777@dunslane.net> Date: Thu, 18 Apr 2024 18:55:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Fix assorted bugs in ecpg's macro mechanism. To: Tom Lane , pgsql-committers@lists.postgresql.org References: From: Andrew Dunstan Content-Language: en-US Autocrypt: addr=andrew@dunslane.net; keydata= xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/ fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw 49QYe1sn2ZPs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-04-16 Tu 12:31, Tom Lane wrote: > Fix assorted bugs in ecpg's macro mechanism. > Buildfarm animals running the old MSVC build system don't like this. It looks to me like we'll need an adjustment in src/tools/msvc/ecpg_regression.proj to replicate the special rules surrounding define.c and define_prelim.c. Not sure who has the requisite knowledge to do that - I don't. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com