Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKcy5-0002KQ-1s for pgsql-committers@arkaria.postgresql.org; Sat, 04 Apr 2020 07:11:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jKcy3-0006Yi-Vd for pgsql-committers@arkaria.postgresql.org; Sat, 04 Apr 2020 07:11:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKcy2-0006YT-Sq for pgsql-committers@lists.postgresql.org; Sat, 04 Apr 2020 07:11:47 +0000 Received: from [64.147.123.21] (helo=wout5-smtp.messagingengine.com) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKcxy-0003Wo-H8 for pgsql-committers@lists.postgresql.org; Sat, 04 Apr 2020 07:11:46 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id BFBDD667; Sat, 4 Apr 2020 03:11:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 04 Apr 2020 03:11:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Uyq/f/cDPOgKKHja/2ndHVKsTE1OoisVtjmq1ziq3 K8=; b=ty8POOmeFfWIPToW5oyrnYGj0oeubggs3t/SXcguN6XFyYV+UyFwhtppD WkshThwLjun40aKn4oY8oGdIPRW+tEN6ovZ3uKfs+xuIkK7ltNnNwzmeCgL0x5Q0 UZTQErerIsIOS+Uu/6SW9mRrje4dzHhbY5qXVaRc9vFJpjRNqSTbC8tRonWxV91E rneihnXY0yFF7UW+5+ryye0uAsZuFsCPBnQL+1NK94fzNVH6jo8um/l7v6Zb/yhR 3Hu2FmxwfgBei+65Yt+wieK5yDjtbrWxHrLMuNI8q+X4LdyRbnjwA+GZasPrS7pz ZkNCZtcNyIlKPfY05WmPss5Lzxjeg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdejgdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvfhfhohfkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvdhnug hquhgrughrrghnthdrtghomheqnecukfhppeelfedrvdegvddrvddufedrvdegudenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrd gvihhsvghnthhrrghuthesvdhnughquhgrughrrghnthdrtghomh X-ME-Proxy: Received: from april.pezone.net (p5df2d5f1.dip0.t-ipconnect.de [93.242.213.241]) by mail.messagingengine.com (Postfix) with ESMTPA id 73F46328005A; Sat, 4 Apr 2020 03:11:27 -0400 (EDT) Subject: Re: pgsql: Improve handling of parameter differences in physical replicatio To: Robert Haas , Andres Freund References: <1f9fb47c-eacc-dc42-3267-20c387fa0a2f@oss.nttdata.com> <20200330181030.z5yiftm65mxvr46p@alap3.anarazel.de> Cc: Fujii Masao , "pgsql-hackers@postgresql.org" , pgsql-committers From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <4fed284b-0396-4453-ba68-a9b7c6d054c7@2ndquadrant.com> Date: Sat, 4 Apr 2020 09:11:25 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 64.147.123.21 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-04-03 19:55, Robert Haas wrote:> I think this patch needs to be reverted. The only places where it > changes anything are places where we were about to throw some error > anyway. But as Andres's analysis shows, that's not nearly good enough. OK, reverted.