Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msVbb-0006qv-VK for pgsql-committers@arkaria.postgresql.org; Wed, 01 Dec 2021 19:49:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1msVba-0000ag-Se for pgsql-committers@arkaria.postgresql.org; Wed, 01 Dec 2021 19:49:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msVba-0000aX-LL for pgsql-committers@lists.postgresql.org; Wed, 01 Dec 2021 19:49:26 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msVbX-0001x8-Pg for pgsql-committers@lists.postgresql.org; Wed, 01 Dec 2021 19:49:26 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 469402EAF350 for ; Wed, 1 Dec 2021 20:49:22 +0100 (CET) Received: from s899.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 36D922F4E595; Wed, 1 Dec 2021 20:49:22 +0100 (CET) Received: from s475.loopia.se (unknown [172.22.191.5]) by s899.loopia.se (Postfix) with ESMTP id 340232C8E5FD; Wed, 1 Dec 2021 20:49:22 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s934.loopia.se ([172.22.191.5]) by s475.loopia.se (s475.loopia.se [172.22.190.15]) (amavisd-new, port 10024) with UTF8LMTP id 9nYXoSJP73eK; Wed, 1 Dec 2021 20:49:21 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from [192.168.72.144] (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id BCF0D7D4861; Wed, 1 Dec 2021 20:49:21 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: pgsql: Add TAP tests for contrib/sslinfo From: Daniel Gustafsson In-Reply-To: <74D032CB-B5EE-4B39-AFBE-67F835A2CBDF@yesql.se> Date: Wed, 1 Dec 2021 20:49:21 +0100 Cc: Tom Lane , pgsql-committers@lists.postgresql.org, Andrew Dunstan Content-Transfer-Encoding: quoted-printable Message-Id: <50312478-6DB6-4A9A-99BF-2EACFF286149@yesql.se> References: <058AAA2B-06CA-4D1C-8D24-B9EA6632C072@yesql.se> <1632478.1638305700@sss.pgh.pa.us> <887628C4-6E1C-4DE5-BA8E-4252BA2B1A0D@yesql.se> <1636597.1638308177@sss.pgh.pa.us> <1686601.1638333261@sss.pgh.pa.us> <74D032CB-B5EE-4B39-AFBE-67F835A2CBDF@yesql.se> To: Michael Paquier X-Mailer: Apple Mail (2.3608.120.23.2.7) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 1 Dec 2021, at 12:49, Daniel Gustafsson wrote: >=20 >> On 1 Dec 2021, at 07:19, Michael Paquier wrote: >>=20 >> On Tue, Nov 30, 2021 at 11:34:21PM -0500, Tom Lane wrote: >>> Daniel Gustafsson writes: >>>> Oh, interesting, I hadn't realized that. I'll go do that instead = then. >>>=20 >>> ... okay, so all we learned is that it really is an ENOENT failure. >>>=20 >>> At this point my guess is that the test is copying the key file >>> to the wrong place because of an MSys path issue. I don't know >>> that topic well enough to debug it, though. >>=20 >> Daniel has pinged me about this issue. =46rom what I can see, = c113d8ad >> has changed 001_ssltests.pl so as the keys are not anymore relative >> paths with *_tmp* names but absolute paths with the same key name, so >> it seems to me that you should sprinkle some perl2host() calls in the >> ${PostgreSQL::Test::Utils::tmp_check} paths to allow Msys to >> understand them. At quick glance, it looks like this is the first >> time we'd pass down absolute paths to libpq within connection >> strings in the TAP tests. >=20 > I think that's a very plausible explanation, I'm currently = experimenting with a > patch that I will soon apply hoping that it will remedy the msys = issue. If it > doesn't, I'll revert to copying inside ssl/ as before to return to the > drawingboard for a proper fix. Looks like perl2host() was the missing piece, fairywren turned green = with commit c3b34a0ff4. Thanks for pointing me in the right direction, I = will draft a small paragraph on this to the TAP test README for other to learn = from. -- Daniel Gustafsson https://vmware.com/