Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjMiD-0005WG-JT for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 14:30:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mjMiA-0001it-EN for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 14:30:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjMiA-0001ik-6z for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 14:30:26 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjMi7-00037o-Rw; Sat, 06 Nov 2021 14:30:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1A6EUJkW508674; Sat, 6 Nov 2021 10:30:20 -0400 From: Tom Lane To: Peter Geoghegan cc: Robert Haas , pgsql-committers Subject: Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup. In-reply-to: References: Comments: In-reply-to Peter Geoghegan message dated "Fri, 05 Nov 2021 18:46:57 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <508672.1636209019.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 06 Nov 2021 10:30:19 -0400 Message-ID: <508673.1636209019@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Geoghegan writes: > On Fri, Nov 5, 2021 at 7:30 AM Robert Haas wrote: >> Introduce 'bbstreamer' abstraction to modularize pg_basebackup. > I'm seeing a pretty straightforward looking compiler warning following > this commit: > bbstreamer_file.c:564:24: warning: unused variable =E2=80=98mystreamer=E2= =80=99 And apparently, that file isn't getting built at all on the MSVC side: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dbowerbird&dt=3D2= 021-11-06%2003%3A52%3A19 regards, tom lane