Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1UANP3-0004MZ-Cb for pgsql-committers@arkaria.postgresql.org; Tue, 26 Feb 2013 16:29:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.72) (envelope-from ) id 1UANP2-0004TI-SD for pgsql-committers@arkaria.postgresql.org; Tue, 26 Feb 2013 16:29:16 +0000 Received: from makus.postgresql.org ([2001:4800:7903:4::125]) by malur.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1UANP2-0004TD-9H for pgsql-committers@postgresql.org; Tue, 26 Feb 2013 16:29:16 +0000 Received: from smtp-outbound-1.vmware.com ([208.91.2.12]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1UANP0-0000HP-Jr for pgsql-committers@postgresql.org; Tue, 26 Feb 2013 16:29:15 +0000 Received: from sc9-mailhost1.vmware.com (sc9-mailhost1.vmware.com [10.113.161.71]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 63EED2874C; Tue, 26 Feb 2013 08:29:13 -0800 (PST) Received: from zcs-prod-ext-mta-1.vmware.com (zcs-prod-ext-mta-1.vmware.com [10.113.62.223]) by sc9-mailhost1.vmware.com (Postfix) with ESMTP id 5FE16187EC; Tue, 26 Feb 2013 08:29:13 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by zcs-prod-ext-mta-1.vmware.com (Postfix) with ESMTP id 625EB1219C5; Tue, 26 Feb 2013 08:32:31 -0800 (PST) X-Virus-Scanned: amavisd-new at zcs-prod-ext-mta-1.vmware.com Received: from zcs-prod-ext-mta-1.vmware.com ([127.0.0.1]) by localhost (zcs-prod-ext-mta-1.vmware.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lldgqu-lGFgW; Tue, 26 Feb 2013 08:32:31 -0800 (PST) Received: from zcs-prod-ext-mta-1.vmware.com (localhost.localdomain [127.0.0.1]) by zcs-prod-ext-mta-1.vmware.com (Postfix) with ESMTP id 3C6E31219C2; Tue, 26 Feb 2013 08:32:31 -0800 (PST) Received: from [192.168.1.90] (unknown [10.113.62.14]) by zcs-prod-ext-mta-1.vmware.com (Postfix) with ESMTPSA; Tue, 26 Feb 2013 08:32:30 -0800 (PST) Message-ID: <512CE2D6.2010204@vmware.com> Date: Tue, 26 Feb 2013 18:29:10 +0200 From: Heikki Linnakangas Organization: VMware User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Thom Brown CC: pgsql-committers Subject: Re: pgsql: Fix pg_dumpall with database names containing = References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -7.6 (-------) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On 26.02.2013 18:03, Thom Brown wrote: > On 20 February 2013 15:14, Heikki Linnakangas wrote: >> Fix pg_dumpall with database names containing = >> >> If a database name contained a '=' character, pg_dumpall failed. The problem >> was in the way pg_dumpall passes the database name to pg_dump on the >> command line. If it contained a '=' character, pg_dump would interpret it >> as a libpq connection string instead of a plain database name. >> >> To fix, pass the database name to pg_dump as a connection string, >> "dbname=foo", with the database name escaped if necessary. >> >> Back-patch to all supported branches. > > I also notice that if you create a database with an "=" in, you can't > connect to it using psql. Specifying it as a connection string works: psql dbname='8=8' That's the same trick I applied to pg_dumpall's pg_dump invocations. - Heikki -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers