From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
In-reply-to: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 05 Apr 2021 01:14:27 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <513199.1617634642.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 05 Apr 2021 10:57:22 -0400
Message-ID: <513200.1617634642@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/513200.1617634642%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Refactor all TAP test suites doing connection checks

Some of the buildfarm seems not to like this.  gaur failed here:

=3D=3D~_~=3D=3D=3D-=3D-=3D=3D=3D~_~=3D=3D pgsql.build/src/test/authenticat=
ion/tmp_check/log/regress_log_001_password =3D=3D~_~=3D=3D=3D-=3D-=3D=3D=3D=
~_~=3D=3D
...
ok 8 - authentication success for method md5, role md5_role
### Reloading node "primary"
# Running: pg_ctl -D /home/bfarm/bf-data/HEAD/pgsql.build/src/test/authent=
ication/tmp_check/t_001_password_primary_data/pgdata reload
server signaled
ack Broken pipe: write( 11, 'SELECT $$connected with user=3Dscram_role$$' =
) at /opt/perl5.8.9/lib/site_perl/5.8.9/IPC/Run/IO.pm line 558

and I think hoverfly's failure is the same thing.

I didn't look at the code, but I bet this is similar to the race
conditions we've seen before where a server process may exit before
the perl test script finishes stuffing a command down the pipe.

			regards, tom lane