Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjOO0-00026r-3b for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 16:17:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mjONy-0003Nz-Ok for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 16:17:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjONy-0003Nq-IL for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 16:17:42 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjONw-0003st-MQ; Sat, 06 Nov 2021 16:17:41 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1A6GHZrs515459; Sat, 6 Nov 2021 12:17:35 -0400 From: Tom Lane To: Tomas Vondra cc: Peter Geoghegan , Robert Haas , pgsql-committers Subject: Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup. In-reply-to: <77ac2e24-051b-d57a-b02e-4dbc3306f895@enterprisedb.com> References: <508673.1636209019@sss.pgh.pa.us> <77ac2e24-051b-d57a-b02e-4dbc3306f895@enterprisedb.com> Comments: In-reply-to Tomas Vondra message dated "Sat, 06 Nov 2021 17:10:27 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <515457.1636215455.1@sss.pgh.pa.us> Date: Sat, 06 Nov 2021 12:17:35 -0400 Message-ID: <515458.1636215455@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Tomas Vondra writes: > I got annoyed by the warning so I marked the variable as assert-only. Thanks! > Haven't done anything about the MSVC issue. I pushed a quick-hack fix for it. Given the ongoing meson work, I'm not inclined to put in a lot of effort there (like teaching the MSVC stuff about BBOBJS). regards, tom lane