From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
cc: Jeff Davis <jdavis@postgresql.org>, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().
In-reply-to: <202511281759.7zxt6cjzikzx@alvherre.pgsql>
References: <202511281759.7zxt6cjzikzx@alvherre.pgsql>
Comments: In-reply-to =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
	message dated "Fri, 28 Nov 2025 19:00:29 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <519379.1764362419.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 28 Nov 2025 15:40:19 -0500
Message-ID: <519380.1764362419@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/519380.1764362419%40sss.pgh.pa.us>
Precedence: bulk

=3D?utf-8?Q?=3DC3=3D81lvaro?=3D Herrera <alvherre@kurilemu.de> writes:
> On 2025-Nov-26, Jeff Davis wrote:
>> Inline pg_ascii_tolower() and pg_ascii_toupper().

> I think this broke the CI on (some flavors of?) Windows.  In
> https://cirrus-ci.com/task/6080935063453696
> I got

> [19:09:39.518] C:/msys64/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/15.2.0=
/../../../../x86_64-w64-mingw32/bin/ld.exe: src/backend/postgres_lib.a.p/c=
ommands_event_trigger.c.obj: in function `filter_list_to_array':
> [19:09:39.518] c:\cirrus\build/../src/backend/commands/event_trigger.c:3=
77:(.text+0x2a5): undefined reference to `pg_ascii_toupper'

That's bizarre.  I checked recent cfbot rebuilds of some of my patches
and there's no problem, also just looking at port.h it's impossible
to see how this could happen.  Some weird compiled-code caching
misbehavior in CI, perhaps?

			regards, tom lane