Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1g7nh9-0000Ce-Bm
	for pgsql-committers@arkaria.postgresql.org; Wed, 03 Oct 2018 20:24:31 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1g7nh7-0008Fe-Gv
	for pgsql-committers@arkaria.postgresql.org; Wed, 03 Oct 2018 20:24:29 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1g7nh7-0008FX-Bx
	for pgsql-committers@lists.postgresql.org; Wed, 03 Oct 2018 20:24:29 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1g7nh5-0007bg-3t
	for pgsql-committers@lists.postgresql.org; Wed, 03 Oct 2018 20:24:28 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w93KONHh000528;
	Wed, 3 Oct 2018 16:24:23 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Ensure that snprintf.c's fmtint() doesn't overflow when
 printing
In-reply-to: <E1g7nZU-0000kU-MB@gemulon.postgresql.org>
References: <E1g7nZU-0000kU-MB@gemulon.postgresql.org>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 03 Oct 2018 20:16:36 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <526.1538598263.1@sss.pgh.pa.us>
Date: Wed, 03 Oct 2018 16:24:23 -0400
Message-ID: <527.1538598263@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Ensure that snprintf.c's fmtint() doesn't overflow when printing INT64_MIN.

Hm, I think you should s/uint64/unsigned long long/ to be consistent
with 595a0eab7.

			regards, tom lane