Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDGbx-0005Si-QU for pgsql-committers@arkaria.postgresql.org; Mon, 18 Jul 2022 02:35:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oDGax-0000AQ-Ts for pgsql-committers@arkaria.postgresql.org; Mon, 18 Jul 2022 02:34:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDGax-0000AH-Mg for pgsql-committers@lists.postgresql.org; Mon, 18 Jul 2022 02:34:51 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDGat-0002Vo-2e for pgsql-committers@lists.postgresql.org; Mon, 18 Jul 2022 02:34:50 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26I2Ygmc532025; Sun, 17 Jul 2022 22:34:42 -0400 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi In-reply-to: <20220718020155.s2soi3niln2skjwi@awork3.anarazel.de> References: <20220718013934.27ukvatuxneyrr2v@awork3.anarazel.de> <20220718020155.s2soi3niln2skjwi@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sun, 17 Jul 2022 19:01:55 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <532023.1658111682.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 17 Jul 2022 22:34:42 -0400 Message-ID: <532024.1658111682@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > I don't know how the configure exec bit got removed, shell history doesn= 't > show anything odd in that regard. I do see a mistake in locally merging = the > symbol-visibility branch (leading to a crucial commit being missed). I d= o see > in shell history that I ran check-world without a failure just before pu= shing, > which should have shown the failure, but didn't. check-world would not have re-run configure even if it was out of date (only config.status), so that part of it's not so surprising. > Definitely a brown paper bag moment. We've all been there :-) regards, tom lane