Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzNd-0004Gw-Qy for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 18:18:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZzNc-0000Gn-Jt for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 18:18:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzNc-0000Ge-Cz for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 18:18:44 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzNZ-0005tT-F4 for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 18:18:43 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id B6B2B1BF206; Thu, 31 Mar 2022 18:18:35 +0000 (UTC) Message-ID: <534ed6b2-6f25-4b0d-4159-2a7f09b61d4b@dunslane.net> Date: Thu, 31 Mar 2022 14:18:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches Content-Language: en-US To: Tom Lane Cc: pgsql-committers@lists.postgresql.org References: <474104.1648685981@sss.pgh.pa.us> <393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net> <479467.1648689140@sss.pgh.pa.us> <230c42b8-5758-3616-b4fd-df9191f0c273@dunslane.net> <648533.1648745441@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: <648533.1648745441@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/31/22 12:50, Tom Lane wrote: > Andrew Dunstan writes: >> There are three ways out of this that I can see: >> . carry a copy of parent.pm in src/test/perl (It's very small) >> . use the older and heavier 'base' module which goes back to 5.004, and >> does much the same thing (and a lot more) >> . just do directly what parent.pm's import() does, as in the attached, >> which I have tested down to version 10. >> On the whole I think I prefer the last. > I like #3 too, given that it's such a small patch. I've verified > that it allows regression tests to run on perl 5.8.8, which is the > oldest I have handy other than prairiedog's 5.8.3 (but that machine > is tied up and I don't feel like trying to test this concurrently > with a buildfarm run). > > I think it's safe enough. Pushed. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com