Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEM0J-0007Hr-2H for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 02:01:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nEM0H-0000z6-E0 for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 02:01:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEM0H-0000yx-6i for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 02:01:13 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEM0F-0008Bm-6y for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 02:01:12 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 20V217ZI535669; Sun, 30 Jan 2022 21:01:07 -0500 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org, Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai In-reply-to: <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de> References: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sun, 30 Jan 2022 17:51:30 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <535667.1643594467.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 30 Jan 2022 21:01:07 -0500 Message-ID: <535668.1643594467@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-01-30 17:35:48 -0800, Andres Freund wrote: >> I see this broke on everywhere but master. Looking. > Ugh. It's that we didn't backport pport.h. Ooops. > Unless somebody comes up with a better idea quickly I'm going use a plai= n > PERL_VERSION check in the backbranches. Might also be a good idea to bac= kpatch > the above commit, but that requires more discussion than I want to leave= the > buildfarm red for. I think we oughta backport. We didn't do so at the time because we thought it was mostly cosmetic/future-proofing, but evidently the future is now. I can look into that tomorrow or so. regards, tom lane