Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaP5t-0001tX-BI for pgsql-committers@arkaria.postgresql.org; Mon, 19 Sep 2022 22:18:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oaP5s-0000q1-8R for pgsql-committers@arkaria.postgresql.org; Mon, 19 Sep 2022 22:18:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaP5s-0000nh-02 for pgsql-committers@lists.postgresql.org; Mon, 19 Sep 2022 22:18:24 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaP5p-0001cR-Ux for pgsql-committers@lists.postgresql.org; Mon, 19 Sep 2022 22:18:23 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28JMIJQd538127; Mon, 19 Sep 2022 18:18:19 -0400 From: Tom Lane To: Peter Geoghegan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Consistently use named parameters in regex code. In-reply-to: References: Comments: In-reply-to Peter Geoghegan message dated "Mon, 19 Sep 2022 22:11:40 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <538125.1663625899.1@sss.pgh.pa.us> Date: Mon, 19 Sep 2022 18:18:19 -0400 Message-ID: <538126.1663625899@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Geoghegan writes: > Consistently use named parameters in regex code. Just scanning this quickly, it looks like you missed the ones hidden behind #ifdef REG_DEBUG, eg dumpstate(). regards, tom lane